The text used to be rendered on the center of the preview grid. When
using the operator too close to a model, it is possible to have the
center of the grid off screen, so it was not visible. In those
situations, the position is clamped so it never goes outside the view, fixing
that issue.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- edit-voxel-size-text-center (branched from master)
- Build Status
Buildable 8623 Build 8623: arc lint + arc unit
Event Timeline
Comment Actions
Consider moving to an utility function, which will take care of giving the final position. The function is already too long, no need to cam everything possible into it.
@Julian Eisel (Severin), how do you fee about using the center? I think more common behavior is to "clamp" to the corner/edge closest to the "pivot".
| source/blender/editors/object/object_remesh.c | ||
|---|---|---|
| 574 | Remove debug print. | |
Comment Actions
From code implementation aspect seems fine.
I'd leave the final decision on the opinion about magnet-to-corner vs. jump-to-center decision up to the UI team.
Comment Actions
Indeed, I have to agree with Sergey here.
The position feels very random to me from looking at the video, it didn't seem predictable. I had to read the patch/description and carefully rewatch to understand the positioning, even then it wasn't really predictable.
This is already an improvement though, it's just that having it clamp to the visible bounds would be much preferable. Similar to how popups are clamped at screen edges.
Comment Actions
@Julian Eisel (Severin) The position is clamped now instead of moved to the center. Is this ok?
Comment Actions
This patch has an approved status however it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect this. This way the patch status still show as Need Review.