Performance: Never draw channels region during playback
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jun 19 2020, 8:23 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Group Reviewers

Animation & Rigging

Maniphest Tasks

T75124: ActionEditor: Keyframes Drawing

Commits

rB28d77f9354de: Performance: Never draw channels region during playback

Summary

Channels aren't visually changed by playing back an animation so there
is no need to do this. As rendering channels is using a lot of logic
(filtering animation data, converting fcurves to samples etc) it has an
noticeable overhead.

Please check if I am correct with the that it is actually not needed I
couldn't think of a reason why it should be.

Spring 02_020_A.anim.blend went from 11.8 to 12.0 on a Ryzen 1700. I
didn't test with scenes but it should be more noticeable with more
complex scenes.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jun 19 2020, 8:23 AM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B8630: Diff 26089.Jun 19 2020, 8:23 AM

Jeroen Bakker (jbakker) added a task: T75124: ActionEditor: Keyframes Drawing.Jun 19 2020, 8:24 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added reviewers: Animation & Rigging, Brecht Van Lommel (brecht), Sergey Sharybin (sergey).

Jeroen Bakker (jbakker) added a project: Performance.

Jeroen Bakker (jbakker) retitled this revision from Performance: Never draw channels region during playback. to Performance: Never draw channels region during playback.Jun 19 2020, 8:27 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 19 2020, 9:08 AM

Yes, its very rare that you would want to modify the graph editor or the dope sheet for that matter while youre playing back the animation 99.9% of the time youd stop playing back first before making edits on it.

Brecht Van Lommel (brecht) accepted this revision.Jun 19 2020, 12:22 PM

This revision is now accepted and ready to land.Jun 19 2020, 12:22 PM

In D8073#196031, @Luciano Muñoz Sessarego (looch) wrote:

Yes, its very rare that you would want to modify the graph editor or the dope sheet for that matter while youre playing back the animation 99.9% of the time youd stop playing back first before making edits on it.

Even that case is covered. This patch doesn't limit functionality at all.

Jeroen Bakker (jbakker) added a child revision: D8066: Performance: Draw play head as an overlay.Jun 19 2020, 2:40 PM

Jeroen Bakker (jbakker) mentioned this in D8066: Performance: Draw play head as an overlay.

Closed by commit rB28d77f9354de: Performance: Never draw channels region during playback (authored by Jeroen Bakker (jbakker)). · Explain WhyJun 19 2020, 2:47 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB28d77f9354de: Performance: Never draw channels region during playback.