Page MenuHome
Differential D8074

Animation: Only update timeline header during playback
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jun 19 2020, 8:50 AM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Group Reviewers
Animation & Rigging
Maniphest Tasks
T75124: ActionEditor: Keyframes Drawing
Commits
rBcc3e808ab478: Animation: Only update timeline header during playback
Summary

The header of all SPACE_ACTIONs are tagged for redraw. Only when the
action editor is showing the timeline it is needed. No noticeable
performance increase. But better to save some CPU cycles.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Jun 19 2020, 8:50 AM
Harbormaster completed remote builds in B8631: Diff 26090.Jun 19 2020, 8:50 AM
Jeroen Bakker (jbakker) requested review of this revision.Jun 19 2020, 8:50 AM
Jeroen Bakker (jbakker) added a reviewer: Animation & Rigging.Jun 19 2020, 8:51 AM
Jeroen Bakker (jbakker) added a project: Performance.
Jeroen Bakker (jbakker) added a task: T75124: ActionEditor: Keyframes Drawing.
Jeroen Bakker (jbakker) updated this revision to Diff 26100.Jun 19 2020, 3:03 PM

Updated with latest master.

Harbormaster completed remote builds in B8635: Diff 26100.Jun 19 2020, 3:03 PM
Sybren A. Stüvel (sybren) accepted this revision.Jun 23 2020, 1:09 PM
Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).

This is a functional change, so calling it "Cleanup" is a misnomer.
Apart from that, LGTM.

This revision is now accepted and ready to land.Jun 23 2020, 1:09 PM
Jeroen Bakker (jbakker) retitled this revision from Cleanup: Only update timeline header during playback to Animation: Only update timeline header during playback.Jun 23 2020, 1:17 PM
Closed by commit rBcc3e808ab478: Animation: Only update timeline header during playback (authored by Jeroen Bakker (jbakker)). · Explain WhyJun 23 2020, 1:20 PM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rBcc3e808ab478: Animation: Only update timeline header during playback.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
screen/
10 lines

Diff 26199

View Options

source/blender/editors/screen/screen_ops.c

Loading...