Paths

Table of Contentst

Differential D8079

EEVEE: Motion Blur: Add accumulation motion blur for better precision
ClosedPublic
Actions

Authored by Clément Foucault (fclem) on Jun 19 2020, 5:44 PM.

Details

Reviewers

Jeroen Bakker (jbakker)

Commits

rB439b40e601f8: EEVEE: Motion Blur: Add accumulation motion blur for better precision

Summary

This revisit the render pipeline to support time slicing for better motion
blur.

We support accumulation with or without the Post-process motion blur.

If using the post-process, we reuse last step next motion data to avoid
another scene reevaluation.

This also adds support for hair motion blur which is handled in a similar
way as mesh motion blur.

The total number of samples is distributed evenly accross all timesteps to
avoid sampling weighting issues. For this reason, the sample count is
(internally) rounded up to the next multiple of the step count.

Only FX Motion BLur:

FX Motion Blur + 4 time steps:

FX Motion Blur + 32 time steps:

Diff Detail

Repository

rB Blender

Branch

eevee-motionblur-timestep (branched from master)

Build Status

Buildable 8641
Build 8641: arc lint + arc unit

Event Timeline

Clément Foucault (fclem) requested review of this revision.Jun 19 2020, 5:44 PM

Clément Foucault (fclem) created this revision.

Harbormaster completed remote builds in B8641: Diff 26114.Jun 19 2020, 5:47 PM

Clément Foucault (fclem) edited the summary of this revision. (Show Details)Jun 19 2020, 5:51 PM

Brecht Van Lommel (brecht) awarded a token.Jun 19 2020, 6:57 PM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Jun 19 2020, 9:00 PM

Zino Guerr (Zino) awarded a token.Jun 20 2020, 1:22 AM

higgsas (higgsas) added a subscriber: higgsas (higgsas).Jun 20 2020, 1:31 AM

Daniel Bystedt (dbystedt) awarded a token.Jun 20 2020, 10:44 AM

Jon Henry M. Faltis 9077149 (295032) awarded a token.Jun 20 2020, 5:37 PM

paul szajner (szap) awarded a token.Jun 20 2020, 5:44 PM

paul szajner (szap) added a subscriber: paul szajner (szap).

Evan Wilson (EAW) awarded a token.Jun 21 2020, 9:35 PM

Firepal64 awarded a token.Jun 21 2020, 9:45 PM

The patch as it is is causing the render to be too dark.

The file I tested was: //scenes/light/coffee_run.B.light.02-apartment.blend:

Render Size 50%
Enable Motion-Blur
Shutter 0.5

Without motion blur:

Without the patch:

With the patch:

This revision now requires changes to proceed.Jun 22 2020, 4:31 PM

Jeroen Bakker (jbakker) added inline comments.Jun 22 2020, 4:42 PM

source/blender/blenloader/intern/versioning_290.c
288	Best check specific for this attribute.

Clément Foucault (fclem) added inline comments.Jun 22 2020, 5:36 PM

source/blender/blenloader/intern/versioning_290.c
288	Ah right this was because I thought it might be committed with part 1.

Fix issue with SSS in large scenes.
Merge branch 'master' into eevee-motionblur-timestep

Harbormaster completed remote builds in B8669: Diff 26175.Jun 22 2020, 7:46 PM

Codewise everything seems clear and fits in current architecture. Optimization hacks have been documented. So only want to do a functional test.

source/blender/draw/engines/eevee/eevee_private.h
598	Consider using a typedef enum. better for debugging...

I checked with the cycles motion blur scene. but I do see some samples to be more visible than others. Could be a limitation of the algorithm or an error.

1 Motion Blur Sample

2 Motion Blur Sample

4 Motion Blur Sample

8 Motion Blur Sample

16 Motion Blur Sample

Overscan does not work, but that is related to T78073: EEVEE new motion blur and overscan produce wrong render

When using cycles motion blur test scene with 256 or more samples it crashes. Seems like the Python post frame handler with factory startup it renders fine. I think it isn't related to this patch.

@Jeroen Bakker (jbakker) this test file has a downside, it has prebaked animation. So sampling the animation at higher frequency reveal the stepping subframe motion caused by animation interpolation (check f-curves and you will see what I mean).

Ah yes I see. Basically I don't have any comments except the few mentioned in the code.

Clément Foucault (fclem) removed a reviewer: Dalai Felinto (dfelinto).Jun 23 2020, 1:56 PM

This revision is now accepted and ready to land.Jun 23 2020, 1:56 PM

Closed by commit rB439b40e601f8: EEVEE: Motion Blur: Add accumulation motion blur for better precision (authored by Clément Foucault (fclem)). · Explain WhyJun 23 2020, 2:06 PM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rB439b40e601f8: EEVEE: Motion Blur: Add accumulation motion blur for better precision.

Lopo Isaac (lopoIsaac) awarded a token.Jun 27 2020, 6:22 AM