Page MenuHome

Unbreak OpenColorIO linkage, if different yaml-cpp libraries are installed
AbandonedPublic

Authored by Marcus von Appen (mva) on Sep 29 2014, 4:16 PM.

Details

Summary

Do not explicitly link against tinyxml and yaml-cpp for OpenColorIO
support. It is not necessary, since OpenColorIO does not export any symbols of
either of those libraries. Instead, it is risky, if OpenColorIO is NOT built
with tinyxml support or linked against a custom libyaml-cpp, which may not be
the one, blender's cmake checks finds first.

It is up to the environment in those cases to provide correct flags, but
should not be done by blender.

Diff Detail

Repository
rB Blender
Branch
ocio-fix

Event Timeline

Marcus von Appen (mva) retitled this revision from to Unbreak OpenColorIO linkage, if different yaml-cpp libraries are installed.
Marcus von Appen (mva) updated this object.
Sergey Sharybin (sergey) requested changes to this revision.Sep 29 2014, 4:29 PM
Sergey Sharybin (sergey) edited edge metadata.

This would break compilation against static version of OCIO.

This revision now requires changes to proceed.Sep 29 2014, 4:29 PM
Marcus von Appen (mva) edited edge metadata.
  • Support static builds for the OpenColorIO fix

Completely wrong branch, will resubmit it for the correct one later on again...

That doesn't seem to be a correct fix still. WITH_STATIC_LIBS only forces CMake to use static libs in favor of dynamic ones. If you've got only a static OCIO library then even without WITH_STATIC_LIBS is will be used. And with the suggested changes blender will fail to link.