Fix T77893: Crash drawmanager threading custom data
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jun 23 2020, 10:51 AM.

Details

Reviewers

Clément Foucault (fclem)
Philipp Oeser (lichtwerk)

Maniphest Tasks

T77893: Crash doing certain modeling operations [customdata_typemap_is_valid]

Commits

rB8f97a64dec35: Fix T77893: Crash drawmanager threading custom data

Summary

Tangent normals were temporarily saved in the original given layers but
the typeinfo wasn't updated. This lead to several issues since we
changed the threading of the mesh extraction.

This patch stores the tangent normals in a temporary custom data on the
stack this way the typemap doesn't need to be updated.

Still need to run the tests for an hour to see if it is fixed

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jun 23 2020, 10:51 AM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B8680: Diff 26194.Jun 23 2020, 10:51 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 23 2020, 10:54 AM

Jeroen Bakker (jbakker) added reviewers: Clément Foucault (fclem), Philipp Oeser (lichtwerk).

Jeroen Bakker (jbakker) added projects: EEVEE & Viewport, BF Blender (2.90).

Cannot comment on code, but survives my tests now

This revision is now accepted and ready to land.Jun 23 2020, 11:59 AM

Jeroen Bakker (jbakker) added 1 blocking reviewer(s): Clément Foucault (fclem).Jun 23 2020, 12:12 PM

This revision now requires review to proceed.Jun 23 2020, 12:12 PM

Wasn't the original intention to avoid recomputing the tangents? I guess nowadays it makes little sense since we have granular batch discard.

This revision is now accepted and ready to land.Jun 23 2020, 2:14 PM

I still think it is wise to cache the tangent normals as they can be heavy to calculate. But on the other hand the tangents are only used for drawing and they are cached in a GPUBatch...

Closed by commit rB8f97a64dec35: Fix T77893: Crash drawmanager threading custom data (authored by Jeroen Bakker (jbakker)). · Explain WhyJun 23 2020, 2:34 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB8f97a64dec35: Fix T77893: Crash drawmanager threading custom data.