Differential D8102

Custom Properties: Allow strings to have a default value
ClosedPublic
Actions

Authored by Demeter Dzadik (Mets) on Jun 24 2020, 1:01 PM.

Tags

None

Subscribers

Brecht Van Lommel (brecht)

Steff Kempink (mswf)

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)

Commits

rB5b03f49302a3: Custom Properties: support default values for strings

Summary

This patch lets String custom properties have a default value, just like floats and ints and arrays.

Use case example: A character outfit swapping system where objects store in custom properties what outfit or outfits they belong to. The user can change that to move the object to another outfit temporarily, but may later want to revert it to its original value.

Code is mostly copy paste from resetting float properties, so I hope it's the correct way.

Diff Detail

Event Timeline

Demeter Dzadik (Mets) requested review of this revision.Jun 24 2020, 1:01 PM

Demeter Dzadik (Mets) created this revision.

Steff Kempink (mswf) added a subscriber: Steff Kempink (mswf).Jun 24 2020, 1:24 PM

Steff Kempink (mswf) added inline comments.

source/blender/makesrna/intern/rna_access.c
3533	You left debug prints here (Thanks for adding this, I ran into this with my scripts too)

Whoops, thanks!

Removed debug prints :)

Brecht Van Lommel (brecht) accepted this revision.Jun 25 2020, 5:32 PM

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Brecht Van Lommel (brecht) added inline comments.

source/blender/makesrna/intern/rna_access.c
3476	Wrong indent, run "make format" to fix it.
3526	This function needs to be updated as well, otherwise the length will not match the returned string.

This revision is now accepted and ready to land.Jun 25 2020, 5:32 PM

Brecht Van Lommel (brecht) requested changes to this revision.Jun 25 2020, 5:32 PM

This revision now requires changes to proceed.Jun 25 2020, 5:32 PM

Fixed not allocating right amount of memory. I think. Thanks Brecht!

I have no idea what I'm doing

Demeter Dzadik (Mets) marked 3 inline comments as done.Jun 29 2020, 8:11 PM

Fixes

Harbormaster completed remote builds in B8777: Diff 26405.Jun 30 2020, 3:09 PM

Brecht Van Lommel (brecht) accepted this revision.Jun 30 2020, 3:09 PM

This revision is now accepted and ready to land.Jun 30 2020, 3:09 PM

Closed by commit rB5b03f49302a3: Custom Properties: support default values for strings (authored by Demeter Dzadik (Mets), committed by Brecht Van Lommel (brecht)). · Explain WhyJun 30 2020, 3:09 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB5b03f49302a3: Custom Properties: support default values for strings.

Revision Contents
Changeset List

Path

Size

release/

scripts/

modules/

2 lines

startup/

bl_operators/

2 lines

source/

blender/

makesrna/

intern/

20 lines

Diff 26222

release/scripts/modules/rna_prop_ui.py

Loading...

release/scripts/startup/bl_operators/wm.py

Loading...

source/blender/makesrna/intern/rna_access.c

Loading...