Differential D8106

Fix T78188: Sculpt mask glitching after using sculpt vertex colors
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Jun 24 2020, 4:45 PM.

Tags

None

Subscribers

None

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T78188: Sculpt mask painting provides heavy shading glitches (today regression)

Commits

rB2b522e3345a4: Fix T78188: Sculpt mask glitching after using sculpt vertex colors

Summary

The face sets color copy to the GPU was done outside of the loop,
probably after a merge error in a rebase.

Also, the default color was initialized using the wrong type.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Jun 24 2020, 4:45 PM

Harbormaster completed remote builds in B8698: Diff 26232.Jun 24 2020, 4:45 PM

Pablo Dobarro (pablodp606) requested review of this revision.Jun 24 2020, 4:45 PM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).Jun 24 2020, 4:46 PM

Sergey Sharybin (sergey) accepted this revision.Jun 24 2020, 5:06 PM

This revision is now accepted and ready to land.Jun 24 2020, 5:06 PM

Closed by commit rB2b522e3345a4: Fix T78188: Sculpt mask glitching after using sculpt vertex colors (authored by Pablo Dobarro (pablodp606)). · Explain WhyJun 24 2020, 5:28 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB2b522e3345a4: Fix T78188: Sculpt mask glitching after using sculpt vertex colors.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

intern/

7 lines

Diff 26238

source/blender/gpu/intern/gpu_buffers.c

Loading...