Page MenuHome

Fix T72214: Fluids: noise does not work with negative frame numbers
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Jun 24 2020, 4:48 PM.

Details

Summary

The issue is duplicated code. There are two functions that zero-fill
the frame number. They worked the same for positive frames numbers, but
behaved differently for negative ones.

This should probably be deduplicated, maybe @Sebastián Barschkis (sebbas) wants to do that.

On frame -100, BLI_path_frame outputs -0100 and
fluid_cache_get_framenr_formatted_$ID$ outputted -100.

I changed the behavior of the latter, because we depend on the behavior
of the former for much longer already.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jun 24 2020, 4:48 PM

So ideally we should get rid of fluid_cache_get_framenr_formatted_$ID$() .. but if I remember correctly I added it so that when debugging with the standalone Manta GUI files could be read.
Will check if there is simple way to replace the function - otherwise we can just use your patch.

Cannot come up with nice way to get rid of fluid_cache_get_framenr_formatted_$ID$(). Let's use this patch for now!

This revision is now accepted and ready to land.Jul 3 2020, 3:09 PM