Differential D8156

Overlay: Edit Text: Remove the need for logic op
ClosedPublic
Actions

Authored by Clément Foucault (fclem) on Jun 30 2020, 12:07 AM.

Details

Reviewers

Campbell Barton (campbellbarton)

Summary

This is just a nice little cleanup but may affect overall readability.

This avoids logic op and having to draw on the render framebuffer.

Current

Patch

Maybe we can tweak to have better visibility.

Related to T75483.

Diff Detail

Repository

rB Blender

Branch

tmp-edit-text-overlay-nologicop (branched from master)

Build Status

Buildable 8766
Build 8766: arc lint + arc unit

Event Timeline

Clément Foucault (fclem) requested review of this revision.Jun 30 2020, 12:07 AM

Clément Foucault (fclem) created this revision.

Harbormaster completed remote builds in B8766: Diff 26391.Jun 30 2020, 12:07 AM

Clément Foucault (fclem) edited the summary of this revision. (Show Details)Jun 30 2020, 12:19 AM

LGTM, committed rB6c7d0aebcbf05f35e256e32603be4b9026c16327

This revision is now accepted and ready to land.Jul 1 2020, 8:57 AM

Campbell Barton (campbellbarton) closed this revision.Jul 1 2020, 8:57 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

overlay/

overlay_edit_text.c

27 lines

overlay_private.h

5 lines

Diff 26391

View Options

source/blender/draw/engines/overlay/overlay_edit_text.c