Differential D8161

Fix T78054: Crash Editing Instanced Objects with Tangent Normals
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jun 30 2020, 12:20 PM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T78054: Crash with Material preview

Commits

rB46ae115b88c4: Fix T78054: Crash Editing Instanced Objects with Tangent Normals

Summary

Similar track as for normal mesh. Don't store the tangent normals in CustomData
of the mesh, but in an unassociated CustomData instance.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Jun 30 2020, 12:20 PM

Harbormaster completed remote builds in B8774: Diff 26401.Jun 30 2020, 12:20 PM

Jeroen Bakker (jbakker) requested review of this revision.Jun 30 2020, 12:20 PM

Jeroen Bakker (jbakker) mentioned this in T78054: Crash with Material preview.Jun 30 2020, 12:23 PM

Removed commented out line

Harbormaster completed remote builds in B8775: Diff 26402.Jun 30 2020, 12:41 PM

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).Jun 30 2020, 12:43 PM

Jeroen Bakker (jbakker) added a project: EEVEE & Viewport.

Jeroen Bakker (jbakker) added a project: BF Blender (2.90).Jun 30 2020, 7:07 PM

Clément Foucault (fclem) accepted this revision.Jun 30 2020, 7:25 PM

This revision is now accepted and ready to land.Jun 30 2020, 7:25 PM

Closed by commit rB46ae115b88c4: Fix T78054: Crash Editing Instanced Objects with Tangent Normals (authored by Jeroen Bakker (jbakker)). · Explain WhyJul 2 2020, 11:35 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB46ae115b88c4: Fix T78054: Crash Editing Instanced Objects with Tangent Normals.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

draw_cache_extract_mesh.c

17 lines

Diff 26451

View Options

source/blender/draw/intern/draw_cache_extract_mesh.c

Fix T78054: Crash Editing Instanced Objects with Tangent NormalsClosedPublicActions