Differential D8168

Minor UI: Fix for File Open - Filter Dropdown - Filter label not correctly showing its inactive/active state
ClosedPublic
Actions

Authored by Adrian Newton (TFS) on Jul 1 2020, 10:25 AM.

Details

Reviewers

Julian Eisel (Severin)

Group Reviewers

User Interface

Commits

rB7d85495ab9e0: UI: Fix File Broswer filter checkbox not connected to label

Diff Detail

Repository: rB Blender

Event Timeline

Adrian Newton (TFS) requested review of this revision.Jul 1 2020, 10:25 AM

Adrian Newton (TFS) created this revision.

Julian Eisel (Severin) added a project: User Interface.Jul 9 2020, 3:45 PM

Looks like a simple fix. But it's a bit too odd that it was this way in the first place, so I'd like to get @Julian Eisel (Severin)'s opinion before changing this.

If the change gets approved, I'd like to add to the changes with.

changing instances of toggle=0 to toggle=False?

In D8168#201492, @Adrian Newton (TFS) wrote:

If the change gets approved, I'd like to add to the changes with.

changing instances of toggle=0 to toggle=False?

Since it's such a quick change I just committed that myself, thanks.

Don't remember details. William and I did tweaks here but there were so many changes, issues like this can slip through.

This revision is now accepted and ready to land.Jul 20 2020, 5:28 PM

Closed by commit rB7d85495ab9e0: UI: Fix File Broswer filter checkbox not connected to label (authored by Adrian Newton (TFS), committed by Julian Eisel (Severin)). · Explain WhyJul 20 2020, 5:37 PM

This revision was automatically updated to reflect the committed changes.

Julian Eisel (Severin) added a commit: rB7d85495ab9e0: UI: Fix File Broswer filter checkbox not connected to label.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

space_filebrowser.py

4 lines

Diff 26991

View Options

release/scripts/startup/bl_ui/space_filebrowser.py

Minor UI: Fix for File Open - Filter Dropdown - Filter label not correctly showing its inactive/active stateClosedPublicActions