Page MenuHome
Differential D8172

Fix missing GPU image free in background mode
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Jul 1 2020, 3:22 PM.

Details

Reviewers
Clément Foucault (fclem)
Commits
rB9949b5098ae8: Fix missing GPU image free in background mode
rBb5660f71fe77: Fix missing GPU image free in background mode
Summary

This is legacy code from before Eevee and Workbench rendering in background
mode was supported. Avoid memory leak by only queueing GPU textures to be
freed when we know they have been allocated.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) created this revision.Jul 1 2020, 3:22 PM
Harbormaster completed remote builds in B8789: Diff 26430.Jul 1 2020, 3:22 PM
Brecht Van Lommel (brecht) requested review of this revision.Jul 1 2020, 3:22 PM
Brecht Van Lommel (brecht) added a comment.Jul 1 2020, 3:23 PM

@Clément Foucault (fclem), I'm not sure if this is tied to any particular bug you were investigating?

Clément Foucault (fclem) accepted this revision.Jul 1 2020, 3:54 PM

LGTM. This might be related to T76989 but I higly doubt this is the case.

This revision is now accepted and ready to land.Jul 1 2020, 3:54 PM
Closed by commit rBb5660f71fe77: Fix missing GPU image free in background mode (authored by Brecht Van Lommel (brecht)). · Explain WhyJul 1 2020, 4:06 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBb5660f71fe77: Fix missing GPU image free in background mode.
Jeroen Bakker (jbakker) added a commit: rB9949b5098ae8: Fix missing GPU image free in background mode.Jul 13 2020, 5:17 PM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
8 lines
gpu/
2 lines
intern/
73 lines
windowmanager/
intern/
2 lines
2 lines

Diff 26432

View Options

source/blender/blenkernel/intern/image.c

Loading...
View Options

source/blender/gpu/GPU_draw.h

Loading...
View Options

source/blender/gpu/intern/gpu_draw.c

Loading...
View Options

source/blender/windowmanager/intern/wm_draw.c

Loading...
View Options

source/blender/windowmanager/intern/wm_init_exit.c

Loading...