Page MenuHome

Apply Modifier: support applying as shape key and keeping the modifier.
ClosedPublic

Authored by Alexander Gavrilov (angavrilov) on Jul 1 2020, 5:30 PM.
Tags
None
Subscribers
None
Tokens
"Love" token, awarded by brilliant_ape."Love" token, awarded by gilberto_rodrigues."Burninate" token, awarded by mywa880.

Details

Summary

This can be useful to save the result of a cloth simulation as a
shape key without destroying the simulation, so it's possible to
e.g. re-run it to get other shapes, or simply use the new shape
key to start the simulation already in a draped state.

Diff Detail

Repository
rB Blender
Branch
temp-angavrilov-save-modifier (branched from master)
Build Status
Buildable 8803
Build 8803: arc lint + arc unit

Event Timeline

Alexander Gavrilov (angavrilov) requested review of this revision.Jul 1 2020, 5:30 PM
Alexander Gavrilov (angavrilov) created this revision.

Functionality seems reasonable, the term save-shape is a bit odd, suggest.

  • Split "Apply Shape Key" into a separate operator.
  • Make removing the modifier option (a toggle) we could should both in the menu.

Split the operator into two so that apply to shape key could be allowed with shared data.

source/blender/modifiers/intern/MOD_ui_common.c
254

I think "Save as Shapekey" makes a more sense here, it's not really "copying" the modifier. Especially because the modifier "Duplicate" operator used to be labeled "Copy".

Minor change, otherwise LGTM.

source/blender/editors/object/object_modifier.c
1378

Naming _inner is odd, normally we use the suffix _ex for extended arguments.

This revision is now accepted and ready to land.Jul 7 2020, 3:48 PM