Differential D8180

BLI: Use TBB spin_mutex as SpinLock implementation
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Jul 2 2020, 4:45 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB0e1ee29f777d: BLI: Use TBB spin_mutex as SpinLock implementation

Summary

BLI: Use TBB spin_mutex as SpinLock implementation

When building without TBB use native to the platform spin lock
implementation. For Windows it is an atomic-based busy-wait,
for Linux it is pthreads' spin lock.

For macOS it is a mutex lock. The reason behind this is to stop
using atomics library which has been declared deprecated in SDK
version 10.12. So this changes fixes a lot of noisy warnings on
the newer SDK.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Jul 2 2020, 4:45 PM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B8802: Diff 26457.Jul 2 2020, 4:45 PM

iAdded static assert to ensure SpinLock alignment

Harbormaster completed remote builds in B8804: Diff 26460.Jul 2 2020, 4:51 PM

Sergey Sharybin (sergey) retitled this revision from BLI: Switch threads implementation file to C++ to BLI: Use TBB spin_mutex as SpinLock implementation.Jul 2 2020, 4:51 PM

Sergey Sharybin (sergey) edited the summary of this revision. (Show Details)

Raise SPinLock back to uint32_t. This allows to fit TBB's spin_mutex
definition for PPC macOS.

Harbormaster completed remote builds in B8806: Diff 26462.Jul 2 2020, 4:56 PM

Sergey Sharybin (sergey) mentioned this in D8179: macOS: upgrade minimum required version to 10.13 High Sierra.Jul 2 2020, 5:24 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 2 2020, 5:41 PM

This revision is now accepted and ready to land.Jul 2 2020, 5:41 PM

Closed by commit rB0e1ee29f777d: BLI: Use TBB spin_mutex as SpinLock implementation (authored by Sergey Sharybin (sergey)). · Explain WhyJul 3 2020, 11:15 AM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB0e1ee29f777d: BLI: Use TBB spin_mutex as SpinLock implementation.