Page MenuHome
Differential D8183

Initial Refactor of code preserving caches during undo.
AbandonedPublic
Actions

Authored by Bastien Montagne (mont29) on Jul 2 2020, 5:45 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Summary

This is a proof od concept, it only implements new system for bSound
data-block as test subject.

Diff Detail

Repository
rB Blender
Branch
undo-caches
Build Status
Buildable 8808
Build 8808: arc lint + arc unit

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Jul 2 2020, 5:45 PM
Bastien Montagne (mont29) created this revision.
Harbormaster completed remote builds in B8808: Diff 26464.Jul 2 2020, 5:45 PM
Bastien Montagne (mont29) updated this revision to Diff 26465.Jul 2 2020, 5:46 PM
  • Cleanup for previous commit.
Harbormaster completed remote builds in B8809: Diff 26465.Jul 2 2020, 5:46 PM
Bastien Montagne (mont29) planned changes to this revision.Jul 2 2020, 5:53 PM

Actually cache key should be defined in BKE, not BLO anymore

Brecht Van Lommel (brecht) added a comment.Jul 2 2020, 6:01 PM

Seems fine overall.

source/blender/blenkernel/intern/sound.c
122–128

Maybe the key can be constructed in the callback, to simplify the code here?

function_callback(id, offsetof(bSound, waveform), &sound->waveform, user_data);
Bastien Montagne (mont29) updated this revision to Diff 26468.Jul 2 2020, 6:04 PM
  • Move cache key struct (and its hashing and compare utils) to BKE_idtype.
Harbormaster completed remote builds in B8810: Diff 26468.Jul 2 2020, 6:04 PM
Bastien Montagne (mont29) mentioned this in rB5dda6cefb64e: Add key structure and hashing utils for ID caches..Jul 3 2020, 12:56 PM
Bastien Montagne (mont29) mentioned this in rB6cb796e98e63: IDTypeInfo: add new callback to loop over all cache pointers of an ID..
Bastien Montagne (mont29) mentioned this in rB5fa6bd8a8ddb: Readfile/Undo: initial refactor of cache preservation code..
Bastien Montagne (mont29) abandoned this revision.Jul 3 2020, 1:00 PM

Committed, thanks.

Bastien Montagne (mont29) mentioned this in D14559: Fix badly broken caches handling during undo/redo..Apr 5 2022, 6:45 PM
Bastien Montagne (mont29) mentioned this in rBe06399c22368: Fix badly broken caches handling during undo/redo..Apr 6 2022, 11:38 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
14 lines
intern/
17 lines
blenloader/
12 lines
intern/
8 lines
7 lines
6 lines
173 lines

Diff 26464

View Options

source/blender/blenkernel/BKE_idtype.h

Loading...
View Options

source/blender/blenkernel/intern/sound.c

Loading...
View Options

source/blender/blenloader/BLO_readfile.h

Loading...
View Options

source/blender/blenloader/intern/readblenentry.c

Loading...
View Options

source/blender/blenloader/intern/readfile.h

Loading...
View Options

source/blender/blenloader/intern/readfile.h.autosave

Loading...
View Options

source/blender/blenloader/intern/readfile.c

Loading...