Differential D8188

Fix T78527: GPencil Mirror modifier is inconsistent with Mesh Mirror
ClosedPublic
Actions

Authored by Philip Holzmann (Foaly) on Jul 2 2020, 8:42 PM.

Tags

Subscribers

None

Details

Reviewers

Antonio Vazquez (antoniov)

Commits

rBa07922159d4a: Fix T78527: GPencil Mirror modifier is inconsistent with Mesh Mirror (redo)

Summary

Simply the same code the regular mesh mirror modifier uses.
Seems to work fine.

Any reason why this was done differently?

Diff Detail

Repository: rB Blender

Event Timeline

Philip Holzmann (Foaly) requested review of this revision.Jul 2 2020, 8:42 PM

Philip Holzmann (Foaly) created this revision.

Philip Holzmann (Foaly) mentioned this in T78527: GPencil: Mirror is inconsistent with Mesh Mirror.Jul 2 2020, 8:45 PM

Philip Holzmann (Foaly) added a reviewer: Antonio Vazquez (antoniov).

The reason to had different code was the modifier was initially totally different and never was cleanup.

Thanks for the patch.

This revision is now accepted and ready to land.Jul 2 2020, 11:00 PM

Closed by commit rBa07922159d4a: Fix T78527: GPencil Mirror modifier is inconsistent with Mesh Mirror (redo) (authored by Philip Holzmann (Foaly), committed by Antonio Vazquez (antoniov)). · Explain WhyJul 2 2020, 11:02 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rBa07922159d4a: Fix T78527: GPencil Mirror modifier is inconsistent with Mesh Mirror (redo).

Revision Contents
Changeset List

Path

Size

source/

blender/

gpencil_modifiers/

intern/

MOD_gpencilmirror.c

61 lines

Diff 26479

source/blender/gpencil_modifiers/intern/MOD_gpencilmirror.c

Loading...