Fix subdivision_set operator not adding new subdivisions
Needs RevisionPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Jul 2 2020, 8:51 PM.

Details

Reviewers

Summary

When using the operator in relative mode it was only adding the first
subidvision to Multires the first time it was used (when the modified was
added). Now it can create a higher level when it does not exist by
pressing the same shortcut again.

Diff Detail

Repository

rB Blender

Branch

fix-multires-switch-levels (branched from master)

Build Status

Buildable 8815
Build 8815: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Jul 2 2020, 8:51 PM

Pablo Dobarro (pablodp606) created this revision.

Harbormaster completed remote builds in B8815: Diff 26480.Jul 2 2020, 8:51 PM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).Jul 2 2020, 8:52 PM

This is a bit weird to have different behavior in sculpt an object mode. This is also different from non-relative mode.
Another issue is that you are only adding one subdivision in relative mode. For example, if the object is at top level 4 and you run the operator with value of 2 i relative mode you end up with final levels of 5.

Please make behavior matched between relative/non-relative, object and sculpt mode. You can also de-duplicate branches here quite a bit.

This revision now requires changes to proceed.Jul 3 2020, 9:13 AM

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_operators/

object.py

2 lines

Diff 26480

View Options

release/scripts/startup/bl_operators/object.py

Fix subdivision_set operator not adding new subdivisionsNeeds RevisionPublicActions