Related to D8187 in order to improve and simplify the modifier panel UI.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- multires-switch-sculpt-levels-op (branched from master)
- Build Status
Buildable 8825 Build 8825: arc lint + arc unit
Event Timeline
Comment Actions
As a feature for the modifier UI, I think this is fine. How it'll be displayed there is a separate question for a different patch/task.
Found one smaller issue, the rest looks fine. Can't speak for the sculpt or multires specific code really, so adding other reviewers.
| source/blender/editors/object/object_modifier.c | ||
|---|---|---|
| 2044 | I think this should use IFACE_(). TIP_() is really just for tooltips, this isn't one. | |
| 2064 | Same here. | |
Comment Actions
It's very subjective but I have some suggestions for the strings.
In general I suggest making them a bit less wordy.
I'm also not sure about phrasing them as questions, but it does help distinguish the action from the description, but maybe there should be a cancel button if it's a question.
| "There are now lower subdivision levels available. This will try to rebuild a lower subdivision level from the current level 0 base mesh." | "No lower subdivision levels available. Rebuild a lower level from the level 0 base mesh?" |
| "There are no higher subdivision levels available. Level %d will be created with %d vertices and %d quads." | "No higher subdivision levels available. Create level %d with %d vertices and %d quads?" |
Comment Actions
Related to D8187 in order to improve and simplify the modifier panel UI.
This is very weak presentation of the work. You should be able to present every change in clear and understandable way: what it does, where it moves project to, how it used, how it will be used, which exact parts of a bigger scale design it implements.
I also do not feel happy with use of those popups. They do not bring clear and meaningful information to artist, they are in a way and are annoying. And most of the time extra subdivision are added because artist needs them, and is not like exposing number of fake vertices to the interface will change anyone's mind.
Also think from a bigger picture, overall system design, and overall user experience. Why is it multires is so much special? How do those popup fit into other areas? How to have strong, useful and helpful interface.
| source/blender/editors/object/object_modifier.c | ||
|---|---|---|
| 2037 | const | |
| 2045–2047 | Same comment as in D8191: don't expose number of grid points as vertices in the interface. Either use proper value, or expose under the name which will not be confused with what actual Vertex count is. Term "quad" is also very weird here, and is ambiguous. | |