Page MenuHome
Differential D8197

Clang Tidy: use .empty() instead of comparing with .size()
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jul 3 2020, 1:49 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rB2633683b5205: Clang-tidy: enable readability-container-size-empty warning
Summary

Just wanted you to check if it compiles for you.
I was wondering, because it does not find the vector.size() == 0
checks in cycles code. That might be, because it's using a subclassed
vector.

Diff Detail

Repository
rB Blender
Branch
size-to-empty (branched from master)
Build Status
Buildable 8828
Build 8828: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Jul 3 2020, 1:49 PM
Harbormaster completed remote builds in B8828: Diff 26503.Jul 3 2020, 1:49 PM
Jacques Lucke (JacquesLucke) requested review of this revision.Jul 3 2020, 1:49 PM
Sergey Sharybin (sergey) accepted this revision.Jul 3 2020, 2:34 PM

Subclass should be fine. AFAIK clang-tidy applies the check to any class which has size() and empty().

The fact that usages in Cycles are not found is because clang-tidy is only enabled in source/ directory. In the future we can selectively enable in intern' as well, but it's a bit more tricky.

From quick look the patch seems correct.

This revision is now accepted and ready to land.Jul 3 2020, 2:34 PM
Closed by commit rB2633683b5205: Clang-tidy: enable readability-container-size-empty warning (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJul 3 2020, 3:01 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB2633683b5205: Clang-tidy: enable readability-container-size-empty warning.

Revision Contents
Changeset List

PathSize
1 line
source/
blender/
blenkernel/
intern/
2 lines
compositor/
intern/
8 lines
freestyle/
intern/
application/
2 lines
blender_interface/
2 lines
geometry/
4 lines
scene_graph/
2 lines
view_map/
2 lines
2 lines
winged_edge/
6 lines
imbuf/
intern/
openexr/
12 lines
io/
alembic/
exporter/
4 lines
2 lines
intern/
4 lines
collada/
10 lines
14 lines
4 lines
4 lines
25 lines
8 lines
2 lines
2 lines
common/
intern/
12 lines

Diff 26503

View Options

.clang-tidy

Loading...
View Options

source/blender/blenkernel/intern/volume.cc

Loading...
View Options

source/blender/compositor/intern/COM_WorkScheduler.cpp

Loading...
View Options

source/blender/freestyle/intern/application/Controller.cpp

Loading...
View Options

source/blender/freestyle/intern/blender_interface/BlenderFileLoader.cpp

Loading...
View Options

source/blender/freestyle/intern/geometry/Grid.cpp

Loading...
View Options

source/blender/freestyle/intern/scene_graph/NodeShape.cpp

Loading...
View Options

source/blender/freestyle/intern/view_map/ViewMapBuilder.cpp

Loading...
View Options

source/blender/freestyle/intern/view_map/ViewMapTesselator.cpp

Loading...
View Options

source/blender/freestyle/intern/winged_edge/WingedEdgeBuilder.cpp

Loading...
View Options

source/blender/imbuf/intern/openexr/openexr_api.cpp

Loading...
View Options

source/blender/io/alembic/exporter/abc_writer_hair.cc

Loading...
View Options

source/blender/io/alembic/exporter/abc_writer_mesh.cc

Loading...
View Options

source/blender/io/alembic/intern/alembic_capi.cc

Loading...
View Options

source/blender/io/collada/AnimationExporter.cpp

Loading...
View Options

source/blender/io/collada/AnimationImporter.cpp

Loading...
View Options

source/blender/io/collada/ArmatureImporter.cpp

Loading...
View Options

source/blender/io/collada/BCAnimationSampler.cpp

Loading...
View Options

source/blender/io/collada/DocumentImporter.cpp

Loading...
View Options

source/blender/io/collada/MeshImporter.cpp

Loading...
View Options

source/blender/io/collada/SkinInfo.cpp

Loading...
View Options

source/blender/io/collada/collada_internal.cpp

Loading...
View Options

source/blender/io/common/intern/abstract_hierarchy_iterator.cc

Loading...