Page MenuHome

Fix T78579: Proxy produces wrong preview when using Offset or Crop
ClosedPublic

Authored by Richard Antalik (ISS) on Jul 4 2020, 7:02 AM.

Details

Summary

Make sure that proxy and original images are scaled to same size before
applying offset or crop.

During testing, I discovered, that raw cache will lose information whether
this image was proxy or not. Because of this, proxy images will not create
this cache type. It would be fairly easy to implement this functionality for
cache, but I have decided to not do it now, because I did not want to pass yet
another mostly hard-coded bool flag to cache system. Since image is proxy, it
should be fast to read anyway.

In case of using offset property, code was modified to make sure we scale
image only once. I also tried to make code more readable and streamlined and
cleaned up surrounding functions a bit.

Diff Detail

Repository
rB Blender
Branch
T78579 (branched from master)
Build Status
Buildable 8836
Build 8836: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Jul 4 2020, 7:02 AM
Brecht Van Lommel (brecht) requested changes to this revision.Jul 6 2020, 6:38 PM
This revision now requires changes to proceed.Jul 6 2020, 6:38 PM
This revision is now accepted and ready to land.Jul 6 2020, 6:39 PM