Details

Germano, is very hard to expose the 'snap gizmo' in python api??? ... if we had access to internal snap in python addons, all these problems would be solved by users with fast and standardized snap.

Julien Kaspar (JulienKaspar) added a subscriber: Julien Kaspar (JulienKaspar).Mar 8 2021, 10:23 AM

Rebase on master

Harbormaster completed remote builds in B13800: Diff 35740.Mar 29 2021, 10:22 PM

Leon Schittek (lone_noel) awarded a token.Mar 29 2021, 10:24 PM

Remove ED_SNAPGIZMO_EVENTSTATE_INGNORE

Harbormaster completed remote builds in B13801: Diff 35741.Mar 29 2021, 10:58 PM

I believe that the patch is ready.

Part of the initial idea regarding the automatic snap to the middle point (as seen in the GIF) has been removed. (This is discussed further in another patch).

One point that can still be considered is the drawing. The circle follows a convection seen in other tools with snapping (measure, transform, add object), but it can also add a lot of information.
However, I didn't want to change much, further complicating the patch.

Knife with snap_gizmo can now snap to other objects? like emptys, curves...
if yes we can use knife as quick slice option for precise interactive cuts..

Correct order of vertex/edge checks

Now the vertex is set after the edge, drawing checks need to be flipped.

Without this the active edge is always drawn, even when the vertex is snapped to.

Harbormaster completed remote builds in B13809: Diff 35753.Mar 30 2021, 7:18 AM

Campbell Barton (campbellbarton) mentioned this in rB52d09dad9c03: Knife: snap refactor, prepare for snap gizmo.Mar 30 2021, 7:20 AM

Extracted a refactor from this patch into master rB52d09dad9c03d2214d1fde20bdc543f70b0174d3

Rebase on master.

Harbormaster completed remote builds in B13810: Diff 35754.Mar 30 2021, 7:24 AM

Mostly fine, noticed some issues though:

There is a bug when using the K-key while the tool is active. When clicking snapping starts at the cursor location when K was pressed.
Having both the snap circle and the knifes own snapping drawing feels cluttered - better only draw one.
The knife tool should the same highlighted circle as is shown before snapping, as the addition of this new snapping gizmo is visibly different before/after the knife tool has begun (while this is a detail, feels odd the way it is currently).
As noted in comments, the object member of the snap gizmo can be removed.

Supporting the snap gizmo in knife_snap_update_from_mval seems like an unnecessary complication, as it requires additional functions that only do something that's already supported when run without the gizmo.

It doesn't seem like we get any advantage from integrating the gizmo while the knife operator is running, AFAICS the gizmo can be hidden/disabled when the modal operator runs.

source/blender/editors/gizmo_library/gizmo_types/snap3d_gizmo.c
93	This doesn't seem to be necessary, it's only used to check if the snap gizmo object is active. However this should already be ensured by `ED_SNAPGIZMO_SNAP_ONLY_ACTIVE`. I'd rather avoid using the snap gizmo to store context which could become outdated, leading to bugs.
source/blender/editors/mesh/editmesh_knife.c
2638	Could use `equals_v3v3_int` here.
2658	`knife_project_v2` could be used here.
source/blender/editors/space_view3d/view3d_gizmo_knife.c
53	C is unused.
76	C, gzgroup, are unused.

This revision now requires changes to proceed.Mar 30 2021, 7:38 AM

In D8220#276445, @Campbell Barton (campbellbarton) wrote:

Extracted a refactor from this patch into master rB52d09dad9c03d2214d1fde20bdc543f70b0174d3

Thanks for the commit :)
(In fact over time I ended up forgetting what was an improvement in the code and what was an addition to the snap gizmo)

In D8220#276429, @Wilsimar (wilBr) wrote:

Knife with snap_gizmo can now snap to other objects? like emptys, curves...
if yes we can use knife as quick slice option for precise interactive cuts..

It is possible, but it needs to be carefully thought of in another patch.

In D8220#276449, @Campbell Barton (campbellbarton) wrote:

Supporting the snap gizmo in knife_snap_update_from_mval seems like an unnecessary complication, as it requires additional functions that only do something that's already supported when run without the gizmo.

It doesn't seem like we get any advantage from integrating the gizmo while the knife operator is running, AFAICS the gizmo can be hidden/disabled when the modal operator runs.

Supporting it for now doesn't really bring much advantage, but the code is still needed to get the first snapping point and in the future it may allow for easy implementation of features like snap to auto midpoint and perpendicular edge.
The only simplicity this would bring is to remove knife_find_closest_edge_of_bmedge.

(coding)

Germano Cavalcante (mano-wii) added a task: T67898: Knife Tool. No preview dot of where the cut will start..Mar 30 2021, 3:26 PM

Vyacheslav (hitrpr) awarded a token.Mar 30 2021, 4:41 PM

Remove unnecessary "ob" member from the snap gizmo
Use "equals_v3v3_int" to compare vetors
Use "knife_project_v2" instead "ED_view3d_project_float_v2_m4"
Comments
Silence warnings: Unused parameter

Harbormaster completed remote builds in B13828: Diff 35778.Mar 30 2021, 4:57 PM

Rebase on master

Harbormaster completed remote builds in B13829: Diff 35781.Mar 30 2021, 5:22 PM

Fix bug when using the K-key while the tool is active
Redo knife drawing

Now the knife tool has a new drawing indicating the "current point".
Before it was a filled green square, now it is a green circle.

This is the same circle as Gizmo, but in Gizmo this circle is red when the operation is not inited.

Harbormaster completed remote builds in B13832: Diff 35784.Mar 30 2021, 6:47 PM

Julien Kaspar (JulienKaspar) awarded a token.Mar 31 2021, 11:23 AM

Remove use of the gizmo snapping system in the knife modal (only use to invoke)

Harbormaster completed remote builds in B13843: Diff 35804.Mar 31 2021, 4:28 PM

Rebase on master
Revert changes in knife design (needs to be better discussed)
Change the color of the gizmo to the TH_HANDLE_SEL_VECT theme (that green one)
Remove snapping option to the middle point (best matches the default knife snapping)

This patch has been simplified to just add a simple gizmo to the knife tool (green circle).
Other changes such as: knife tool design, auto snap to middle point and snap to perpendicular are out of scope.
These changes can be thought of later.

Harbormaster completed remote builds in B13855: Diff 35830.Apr 1 2021, 6:18 PM

so bad :-(

Maybe you can add snap_gizmo to bisect tool.... for start and end points.

We need some 'quick precise slice' tool with snap to other objects outside of current editing mesh.... bisect tool with snap_gizmo maybe to do the work.
:-)

Snap Gizmo: Add 'SNAP_GEOM_EDIT_DEFORMED'
Knife Tool Widget: snap to deformed cage

Harbormaster completed remote builds in B14086: Diff 36259.Apr 18 2021, 4:53 AM

Fixes
Cleanup

Harbormaster completed remote builds in B14087: Diff 36260.Apr 18 2021, 3:46 PM

Fix crash in Measure tool

Harbormaster completed remote builds in B14088: Diff 36261.Apr 18 2021, 3:58 PM

Rebase on master

Harbormaster completed remote builds in B14093: Diff 36269.Apr 19 2021, 1:50 AM

Campbell Barton (campbellbarton) added inline comments.Apr 19 2021, 4:44 AM

source/blender/editors/include/ED_gizmo_library.h
275	See note on `SNAP_GEOM_EDIT_DEFORMED`, the docstring could be linked from here.
source/blender/editors/include/ED_transform_snap_object_context.h
54–59	While CAGE can work in object mode and `SNAP_GEOM_EDIT_DEFORMED` can't be, they seem as if they would be quite similar. It would be good to include a doc-string explaining the difference between the two (for e.g. handling of hidden geometry).

Add comments

This patch will now follow with changes in D11010: Snap: Implement a new option to snap to a bmesh adapted to the cage

Harbormaster completed remote builds in B14096: Diff 36275.Apr 19 2021, 7:44 AM

Rebase on tmp-snap-bmesh-cageco

Harbormaster completed remote builds in B14098: Diff 36277.Apr 19 2021, 7:54 AM

HEYPictures (HEYPictures) awarded a token.Apr 19 2021, 9:09 AM

Use Snap Gizmo for the knife tool widget
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 36275

release/scripts/startup/bl_ui/space_toolsystem_toolbar.py

source/blender/blenkernel/BKE_bvhutils.h

source/blender/blenkernel/intern/bvhutils.c

source/blender/editors/gizmo_library/gizmo_types/snap3d_gizmo.c

source/blender/editors/include/ED_gizmo_library.h

source/blender/editors/include/ED_transform_snap_object_context.h

source/blender/editors/mesh/editmesh_knife.c

source/blender/editors/space_view3d/CMakeLists.txt

source/blender/editors/space_view3d/space_view3d.c

source/blender/editors/space_view3d/view3d_gizmo_knife.c

source/blender/editors/space_view3d/view3d_intern.h

source/blender/editors/transform/transform_snap_object.c

Use Snap Gizmo for the knife tool widgetNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36275

release/scripts/startup/bl_ui/space_toolsystem_toolbar.py

source/blender/blenkernel/BKE_bvhutils.h

source/blender/blenkernel/intern/bvhutils.c

source/blender/editors/gizmo_library/gizmo_types/snap3d_gizmo.c

source/blender/editors/include/ED_gizmo_library.h

source/blender/editors/include/ED_transform_snap_object_context.h

source/blender/editors/mesh/editmesh_knife.c

source/blender/editors/space_view3d/CMakeLists.txt

source/blender/editors/space_view3d/space_view3d.c

source/blender/editors/space_view3d/view3d_gizmo_knife.c

source/blender/editors/space_view3d/view3d_intern.h

source/blender/editors/transform/transform_snap_object.c

Use Snap Gizmo for the knife tool widget
Needs ReviewPublic
Actions

Revision Contents
Changeset List