CustomData: add float2 and float3 data types
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jul 8 2020, 5:43 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB57ec1f37e9a8: CustomData: add float2 and float3 data types

Summary

This adds CD_PROP_FLOAT2 and CD_PROP_FLOAT3.
"Float2" and "Float3" don't necessarily have to be used in the UI.
Have a look at T71384 to see how data types are called in different programs.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Jul 8 2020, 5:43 PM

Harbormaster completed remote builds in B8912: Diff 26635.Jul 8 2020, 5:43 PM

Jacques Lucke (JacquesLucke) requested review of this revision.Jul 8 2020, 5:43 PM

Jacques Lucke (JacquesLucke) added a reviewer: Brecht Van Lommel (brecht).Jul 8 2020, 5:45 PM

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/blenkernel/intern/customdata.c
1900	The `N_("Float3")` name should not be used. I just have to provide a default name to tell the system that multiple layers of this type can exist.

fix typo

Harbormaster completed remote builds in B8913: Diff 26636.Jul 8 2020, 5:49 PM

Hi @Jacques Lucke (JacquesLucke) , I was also working on CD_PROP_VECTOR (I only looked at 3d, but 2d should be there as well, right), but including appropriate LayerTypeInfo functions (interp, equal, add, ...).
Think it would be good to have these included right away [to provide something for modeling tools to treat CD_PROP layers properly]?

Will post what I have later today.

Philipp Oeser (lichtwerk) added inline comments.Jul 9 2020, 9:45 AM

source/blender/makesdna/DNA_customdata_types.h
214–216	in D8200, this will be replaced by `CD_MASK_PROP_ALL`. (just saying, depends on what will land first)

@Philipp Oeser (lichtwerk) Feel free to post/commit what you have. I don't need all the interpolation stuff yet, so I did not add it.

I prefer the internal name CD_PROP_FLOAT3 over CD_PROP_VECTOR. It is more explicit and matches the C++ type name defined in BLI_float3.hh.

In D8251#200496, @Jacques Lucke (JacquesLucke) wrote:

@Philipp Oeser (lichtwerk) Feel free to post/commit what you have. I don't need all the interpolation stuff yet, so I did not add it.

I prefer the internal name CD_PROP_FLOAT3 over CD_PROP_VECTOR. It is more explicit and matches the C++ type name defined in BLI_float3.hh.

Unfortunately I didnt get to finish it before my holidays [which have started now], so from my side, go ahead, we can always add relevant functions later.

I think interpolation and similar functions should be added along with this, would rather not commit this half-finished.

This revision now requires changes to proceed.Jul 13 2020, 7:51 PM

I added some of the callbacks. I noticed that CD_PROP_FLOAT
and CD_PROP_INT32 don't have most of the callbacks either.

Unfortunately, I don't really know how to test these callbacks
in a good way. They compile for me, but I've never called them...

Harbormaster completed remote builds in B9017: Diff 26824.Jul 15 2020, 3:48 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 15 2020, 4:30 PM

This revision is now accepted and ready to land.Jul 15 2020, 4:30 PM

Adding similar functions for CD_PROP_FLOAT would be good as well.

These generic attributes are quite hidden not used much, but when they start getting exposed in the UI this will become a problem.

Closed by commit rB57ec1f37e9a8: CustomData: add float2 and float3 data types (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJul 15 2020, 4:44 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB57ec1f37e9a8: CustomData: add float2 and float3 data types.