Page MenuHome
Differential D8254

Rename the assets app
ClosedPublic
Actions

Authored by Natalia Maniakowska (natka) on Jul 9 2020, 11:38 AM.

Details

Reviewers
Francesco Siddi (fsiddi)
Maniphest Tasks
T78741: Rename the assets app
Commits
rBLS36d805b1946a: Add arcanist config
rBLS49431a6137f2: Fix comments
rBLS3c062d23dd0c: Add arcanist config
rBLS6c9e2aa0b50a: Fix comments
rBLS88bba1bef4e6: Rename the assets app to static_assets
Summary
  • Fix errors due to thumbnails in tests. Improve factories.
  • Squash migrations: assets, films. Migrations are squashed in such way as to avoid circular dependencies.
  • Additional films migration after squashing
  • Remove non-squashed migrations from assets, films
  • Rename the assets app to static_assets
  • Adjust the static_assets app name in docs
  • Create migrations that rename db tables in renamed app
  • Add arcanist config

Diff Detail

Event Timeline

Natalia Maniakowska (natka) requested review of this revision.Jul 9 2020, 11:38 AM
Natalia Maniakowska (natka) created this revision.
Harbormaster completed remote builds in B8920: Diff 26646.Jul 9 2020, 11:38 AM
Francesco Siddi (fsiddi) requested changes to this revision.Jul 9 2020, 11:42 AM
Francesco Siddi (fsiddi) added a subscriber: Francesco Siddi (fsiddi).

Just a minor comment.

films/tests/test_previous_next_asset.py
103 ↗(On Diff #26646)

Comments start with capital letter :)

This revision now requires changes to proceed.Jul 9 2020, 11:42 AM
Natalia Maniakowska (natka) updated this revision to Diff 26647.Jul 9 2020, 11:43 AM

Fix comments

Harbormaster completed remote builds in B8921: Diff 26647.Jul 9 2020, 11:43 AM
Natalia Maniakowska (natka) marked an inline comment as done.Jul 9 2020, 11:45 AM
Francesco Siddi (fsiddi) accepted this revision.Jul 9 2020, 11:46 AM
This revision is now accepted and ready to land.Jul 9 2020, 11:46 AM
Ankit Meel (ankitm) added a task: T78741: Rename the assets app.Jul 9 2020, 11:57 AM
Natalia Maniakowska (natka) retitled this revision from Just a test arc diff to Rename the assets app.Jul 9 2020, 12:45 PM
Natalia Maniakowska (natka) edited the summary of this revision. (Show Details)
Closed by commit rBLS88bba1bef4e6: Rename the assets app to static_assets (authored by Natalia Maniakowska (natka)). · Explain WhyJul 9 2020, 12:53 PM
This revision was automatically updated to reflect the committed changes.
Natalia Maniakowska (natka) added a commit: rBLS88bba1bef4e6: Rename the assets app to static_assets.
Natalia Maniakowska (natka) added a commit: rBLS6c9e2aa0b50a: Fix comments.
Natalia Maniakowska (natka) added a commit: rBLS3c062d23dd0c: Add arcanist config.Jul 9 2020, 12:57 PM
Natalia Maniakowska (natka) added a commit: rBLS49431a6137f2: Fix comments.
Natalia Maniakowska (natka) added a commit: rBLS36d805b1946a: Add arcanist config.Jul 9 2020, 3:37 PM

Revision Contents
Changeset List

PathSize
3 lines

Diff 26652

View Options

.arcconfig

Loading...