This patch fixes MinGW64 compiler errors below introduced by D643:
- undefined symbol ERROR_PROFILE_DOES_NOT_MATCH_DEVICE (0x7E7).
- "jump to label crosses initialization" errors.
Contributor: aligorith (Joshua Leung) as to the undefined symbol.
Differential D825
MinGW64 compilation fix for D643 Ghost Context Refactor. Authored by Antonis Ryakiotakis (psy-fi) on Oct 11 2014, 5:34 AM.
Details
This patch fixes MinGW64 compiler errors below introduced by D643:
Contributor: aligorith (Joshua Leung) as to the undefined symbol.
Diff Detail Event TimelineComment Actions Changes in GHOST_Context.cpp have already been committed in the mean time. Revisions in GHOST_ContextWGL.cpp are intended to fix compilation errors reported by @Joshua Leung (aligorith):
Comment Actions I see, the values aren't used in this case, (the goto isnt reading the values)... its a bit messy but since its is simple working code, just leave it?... That, or get a full mingw build log from ghost/win32 and collect warnings and quiet (all/most) of them. Comment Actions Just confirming that we had the same issues as Aligorith and kjym3 here with Windows/MinGW64 and our own patch was nessecary to fix this. Comment Actions I think I've fixed these issues now. I decided to remove all intermixed decls in functions that use goto, for consistency. I would have used something like boost::optional to manage these resources, but the protocol isn't that simple. Comment Actions I think I could commit all of these remaining changes. My only question is whether the change to the type of embedder window should also be changed for msvc when compiling for 64 bit. |