Fix the eevee sky zenith bug
ClosedPublic
Actions

Authored by Szymon Ulatowski (szulat) on Jul 10 2020, 2:48 PM.

Details

Reviewers

Commits

rB29da019cb353: EEVEE: Fix sky zenith bug

Summary

Careless use of acos() in spherical coordinates transformation was
deteriorating the precision near zenith (and nadir) and producing
glitchy pixels (best seen in longer focal lengths).

Diff Detail

Repository: rB Blender

Event Timeline

Szymon Ulatowski (szulat) requested review of this revision.Jul 10 2020, 2:48 PM

Szymon Ulatowski (szulat) created this revision.

Harbormaster completed remote builds in B8954: Diff 26696.Jul 10 2020, 2:48 PM

Brecht Van Lommel (brecht) added a reviewer: Clément Foucault (fclem).Jul 10 2020, 2:49 PM

Clément Foucault (fclem) accepted this revision.Jul 13 2020, 4:18 PM

This revision is now accepted and ready to land.Jul 13 2020, 4:18 PM

Closed by commit rB29da019cb353: EEVEE: Fix sky zenith bug (authored by Szymon Ulatowski (szulat), committed by Clément Foucault (fclem)). · Explain WhyJul 13 2020, 4:25 PM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rB29da019cb353: EEVEE: Fix sky zenith bug.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

shaders/

material/

gpu_shader_material_tex_sky.glsl

2 lines

Diff 26753

View Options

source/blender/gpu/shaders/material/gpu_shader_material_tex_sky.glsl

Fix the eevee sky zenith bugClosedPublicActions