Page MenuHome
Differential D8271

This commit fixes T70142
ClosedPublic
Actions

Authored by Fabrício Luis (ce3po) on Jul 11 2020, 6:12 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T70142: Implement Center View to Cursor (Shift + C) in the Image Editor

Diff Detail

Repository
rB Blender
Branch
arcpatch-D8271 (branched from master)
Build Status
Buildable 9219
Build 9219: arc lint + arc unit

Event Timeline

Fabrício Luis (ce3po) requested review of this revision.Jul 11 2020, 6:12 AM
Fabrício Luis (ce3po) created this revision.
Harbormaster completed remote builds in B8966: Diff 26716.Jul 11 2020, 6:13 AM
Jacques Lucke (JacquesLucke) added a task: T70142: Implement Center View to Cursor (Shift + C) in the Image Editor.Jul 11 2020, 7:54 AM
Jacques Lucke (JacquesLucke) added a reviewer: Campbell Barton (campbellbarton).
Campbell Barton (campbellbarton) requested changes to this revision.Jul 11 2020, 12:56 PM
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/space_image/image_ops.c
854

Normally we don't call exec functions directly, this should be moved into a utility function.

858–860

Poll will catch this, if not, the exec function would have already crashed - from calling view all above.

This revision now requires changes to proceed.Jul 11 2020, 12:56 PM
Fabrício Luis (ce3po) updated this revision to Diff 26722.Jul 12 2020, 5:50 AM
  • Include utility function ED_Image_view_all
Harbormaster completed remote builds in B8969: Diff 26722.Jul 12 2020, 5:50 AM
Fabrício Luis (ce3po) updated this revision to Diff 26723.Jul 12 2020, 6:31 AM
  • Remove warning ED_Image_view_all
Harbormaster completed remote builds in B8970: Diff 26723.Jul 12 2020, 6:31 AM
Campbell Barton (campbellbarton) accepted this revision.Jul 15 2020, 1:30 PM
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/space_image/image_ops.c
809

This could be moved to View Navigation Utilities, currently this isn't in a group.

This revision is now accepted and ready to land.Jul 15 2020, 1:30 PM
Fabrício Luis (ce3po) updated this revision to Diff 27196.Jul 28 2020, 8:07 PM
  • Moved image_view_all() to View Navigation Utilities
Harbormaster completed remote builds in B9219: Diff 27196.Jul 28 2020, 8:07 PM
Dalai Felinto (dfelinto) added a project: Modeling.Aug 28 2020, 3:06 PM
Yevgeny Makarov (jenkm) added a subscriber: Yevgeny Makarov (jenkm).Jan 5 2021, 4:22 PM

Labels should be properly capitalized, descriptions in lowercase.
https://wiki.blender.org/wiki/Human_Interface_Guidelines/Writing_Style

"Cursor to Center View"
"Set 2D cursor to center view location"
Campbell Barton (campbellbarton) mentioned this in rB8e6e8dd871f2: UV Editor: Add cursor center operator.Mar 27 2021, 5:08 AM
Campbell Barton (campbellbarton) closed this revision.EditedMar 27 2021, 5:40 AM

Thanks, committed rB8e6e8dd871f2db931bc730ac0a49cdad532f40fb

Revision Contents
Changeset List

PathSize
release/
scripts/
presets/
keyconfig/
keymap_data/
1 line
source/
blender/
editors/
include/
2 lines
space_image/
1 line
166 lines
1 line

Diff 27196

View Options

release/scripts/presets/keyconfig/keymap_data/blender_default.py

Loading...
View Options

source/blender/editors/include/ED_image.h

Loading...
View Options

source/blender/editors/space_image/image_intern.h

Loading...
View Options

source/blender/editors/space_image/image_ops.c

Loading...
View Options

source/blender/editors/space_image/space_image.c

Loading...