Page MenuHome

Sculpt: Improve Front Faces Only option
Needs RevisionPublic

Authored by Pablo Dobarro (pablodp606) on Jul 12 2020, 7:26 PM.
Tags
None
Subscribers
None
Tokens
"Love" token, awarded by julperado."Like" token, awarded by 14AUDDIN."Burninate" token, awarded by DiogoX2."Love" token, awarded by ace_dragon."Love" token, awarded by Brandon777.

Details

Summary

This option was using the dot product between the view normal and the
vertex normal to mask vertices. This was causing artifacts and affecting
the shape of the brush tip on curved and irregular surfaces, as well as
artifacts in areas with high frequency detail.

Now it uses a weighted average of the vertex normal and its neighbors
with a smoothstep falloff in a defined area. It still produces some
artifacts with highly deformed topology, but the results are much better
in general.

I also renamed and cleaned up the function using the sculpt API in order
to move this functionality to the automasking system in a later
refactor.

Before

After

Diff Detail

Repository
rB Blender
Branch
improve-front-faces (branched from master)
Build Status
Buildable 8972
Build 8972: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Jul 12 2020, 7:26 PM
Sergey Sharybin (sergey) requested changes to this revision.Jul 13 2020, 10:24 AM
Sergey Sharybin (sergey) added inline comments.
source/blender/editors/sculpt_paint/sculpt.c
1711

What is the geometric meaning of this?

1720

dot is too generic, it is a projection.

1729–1730

Why is it 2?

1739

I don't know what is the result of comparing projection with hardness.
This needs better explanation.

This revision now requires changes to proceed.Jul 13 2020, 10:24 AM