Page MenuHome
Differential D8278

Fix extrude face not working with Correct face attributes
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Jul 13 2020, 2:08 PM.
Tags
  • Restricted Project
Subscribers
None
Tokens
"Love" token, awarded by Kickflipkid687."Love" token, awarded by franMarz.

Details

Reviewers
Campbell Barton (campbellbarton)
Commits
rB5e232d7a0ba2: Fix bad 'Correct Face Attributes' behavior when extruding faces
Summary

Part of T78671

A face must have area in order to be possible calculate interpolation weights.
The same to the reference UVs.
But the new faces created with the extrude operator, have no area (before moving).

The solution I found was to get the loop data from some neighbor face.

The concern in this patch is in the code described as "Hack" in the comments.
Not that it brings a problem, it's just not a usual solution.

Diff Detail

Repository
rB Blender
Branch
transform_customdata_extrude (branched from master)
Build Status
Buildable 8978
Build 8978: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Jul 13 2020, 2:08 PM
Germano Cavalcante (mano-wii) created this revision.
Harbormaster completed remote builds in B8978: Diff 26748.Jul 13 2020, 2:08 PM
Germano Cavalcante (mano-wii) added a project: Restricted Project.Jul 13 2020, 2:14 PM
Fran Marz (franMarz) awarded a token.Jul 15 2020, 5:42 PM
Germano Cavalcante (mano-wii) planned changes to this revision.Jul 17 2020, 7:53 PM

Broken by rB8b0df381d953: Transform: use GHASH_ITER when restoring customdata

Germano Cavalcante (mano-wii) updated this revision to Diff 26937.Jul 17 2020, 10:00 PM
  • Reference the substitute face in the normal of the original face.
Harbormaster completed remote builds in B9087: Diff 26937.Jul 17 2020, 10:01 PM
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Jul 17 2020, 10:03 PM
Matt (Kickflipkid687) awarded a token.Jul 17 2020, 10:49 PM
Campbell Barton (campbellbarton) accepted this revision.EditedJul 21 2020, 11:02 AM

I've made a small update to the patch that makes some small changes that.

P1539

  • Use USE_FACE_SUBSTITUTE for the hack.
  • Keep the current lookup logic inline instead of moving them into a function just for this change.

Tested with D8279 and it works well.

This revision is now accepted and ready to land.Jul 21 2020, 11:02 AM
Germano Cavalcante (mano-wii) updated this revision to Diff 27015.Jul 21 2020, 1:43 PM
  • Improve the hack a little
  • Re inline code
  • Comments

I will commit as soon as I find a better solution for D8279

Harbormaster completed remote builds in B9129: Diff 27015.Jul 21 2020, 1:43 PM
Closed by commit rB5e232d7a0ba2: Fix bad 'Correct Face Attributes' behavior when extruding faces (authored by Germano Cavalcante (mano-wii)). · Explain WhyJul 28 2020, 2:55 PM
This revision was automatically updated to reflect the committed changes.
Germano Cavalcante (mano-wii) added a commit: rB5e232d7a0ba2: Fix bad 'Correct Face Attributes' behavior when extruding faces.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
transform/
65 lines

Diff 26748

View Options

source/blender/editors/transform/transform_convert_mesh.c

Loading...