Fix T42209: Changing Node Editor header color also changes wire color
ClosedPublic
Actions

Authored by Kévin Dietrich (kevindietrich) on Oct 13 2014, 11:19 PM.

Details

Reviewers

Lukas Tönne (lukastoenne)

Maniphest Tasks

T42209: Changing Node Editor header color also changes wire color

Commits

rBSc08e7e1dc036: Fix T42209: Changing Node Editor header color also changes wire color
rBc08e7e1dc036: Fix T42209: Changing Node Editor header color also changes wire color

Summary

The nodes wire was using 'TH_HEADER' flag to get its color and thus would be in sync with the header. Now make it so it uses its 'own' flag (actually 'TH_SYNTAX_R', the only TH_SYNTAX_* which wasn't yet used by the nodes).
Also expose the setting to the user so it can be themified.

This fixes T42209

Diff Detail

Repository: rB Blender

Event Timeline

Kévin Dietrich (kevindietrich) updated this revision to Diff 2715.Oct 13 2014, 11:19 PM

Kévin Dietrich (kevindietrich) retitled this revision from to Fix T42209 Changing Node Editor header color also changes wire color.

Kévin Dietrich (kevindietrich) updated this object.

Kévin Dietrich (kevindietrich) added a reviewer: Lukas Tönne (lukastoenne).

Kévin Dietrich (kevindietrich) retitled this revision from Fix T42209 Changing Node Editor header color also changes wire color to Fix T42209: Changing Node Editor header color also changes wire color.Oct 13 2014, 11:20 PM

Kévin Dietrich (kevindietrich) updated this object.

Kévin Dietrich (kevindietrich) added a task: T42209: Changing Node Editor header color also changes wire color.

Just a few naming nit-picks, other than that LGTM.

source/blender/editors/space_node/drawnode.c
3447	Would suggest to add a new `TH_NODE_WIRE` or so to the enum in UI_resources.h, instead of reusing the `TH_SYNTAX_R` value which doesn't make any sense in a node context. You can still map it to the same DNA field from `ThemeSpace` in `UI_ThemeGetColorPtr`, we have a number of places where this is done.
source/blender/makesrna/intern/rna_userdef.c
2040	Would be nice to have a description string here what these colors are used for (also for "wire") - helps users setting them up correctly in themes.