Page MenuHome
Differential D8282

Deps:Build openvdb as a shared lib on windows
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Jul 13 2020, 6:09 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBe691a3a9b7f3: Deps_builder: Update openvdb to a dynamic library
Summary

prep for pyopenvdb ( D8123 )

Note: this will only change openvdb to be build as a shared library.

pyopenvdb will not build/link yet as further patches are needed
to make it deal nicely with static boost (unless we want to move
boost dynamic as well)

Not looking to land this until 2.91 (but we currently do not have a 2.91 tag yet) so no rush to review it.

Diff Detail

Repository
rB Blender
Branch
tmp_dynamic_openvdb_update (branched from master)
Build Status
Buildable 9505
Build 9505: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) created this revision.Jul 13 2020, 6:09 PM
Harbormaster completed remote builds in B8985: Diff 26765.Jul 13 2020, 6:09 PM
Ray Molenkamp (LazyDodo) requested review of this revision.Jul 13 2020, 6:09 PM
Ray Molenkamp (LazyDodo) edited the summary of this revision. (Show Details)Jul 13 2020, 6:15 PM
Ray Molenkamp (LazyDodo) added a subscriber: Tuomo Keskitalo (tkeskita).
Brecht Van Lommel (brecht) added inline comments.Jul 13 2020, 7:09 PM
build_files/build_environment/patches/openvdb.diff
61

NOT instead of !

extern/mantaflow/CMakeLists.txt
67–69

NOT instead of !

Ray Molenkamp (LazyDodo) added a project: BF Blender (2.91).Jul 13 2020, 7:11 PM
Ray Molenkamp (LazyDodo) updated this revision to Diff 26770.Jul 13 2020, 7:13 PM
Ray Molenkamp (LazyDodo) edited the summary of this revision. (Show Details)
  • Change ! to NOT
Harbormaster completed remote builds in B8990: Diff 26770.Jul 13 2020, 7:13 PM
Ray Molenkamp (LazyDodo) marked 2 inline comments as done.Jul 13 2020, 7:13 PM
Brecht Van Lommel (brecht) accepted this revision.Jul 13 2020, 7:13 PM
This revision is now accepted and ready to land.Jul 13 2020, 7:13 PM
Ray Molenkamp (LazyDodo) mentioned this in D8123: Build pyopenvdb as part of make deps.Jul 15 2020, 5:26 PM
Ray Molenkamp (LazyDodo) updated this revision to Diff 27714.Aug 13 2020, 4:43 PM
  • Add version info to the dlls
  • Merge remote-tracking branch 'origin/master' into tmp_dynamic_openvdb_update

The shared dlls had no version information which is troublesome if we ever have
to update them in a bug fix release.

Harbormaster completed remote builds in B9505: Diff 27714.Aug 13 2020, 4:43 PM
Ray Molenkamp (LazyDodo) updated this revision to Diff 27715.Aug 13 2020, 4:46 PM
  • minimize changes to the openvdb diff
Harbormaster completed remote builds in B9506: Diff 27715.Aug 13 2020, 4:46 PM
Closed by commit rBe691a3a9b7f3: Deps_builder: Update openvdb to a dynamic library (authored by Ray Molenkamp (LazyDodo)). · Explain WhyAug 13 2020, 7:42 PM
This revision was automatically updated to reflect the committed changes.
Ray Molenkamp (LazyDodo) mentioned this in rBL62478: Windows: OpenVDB 7.0.0 shared library..
Ray Molenkamp (LazyDodo) added a commit: rBe691a3a9b7f3: Deps_builder: Update openvdb to a dynamic library.

Revision Contents
Changeset List

PathSize
build_files/
build_environment/
cmake/
18 lines
patches/
121 lines
cmake/
platform/
8 lines
extern/
mantaflow/
4 lines
source/
creator/
13 lines

Diff 27714

View Options

build_files/build_environment/cmake/openvdb.cmake

Loading...
View Options

build_files/build_environment/patches/openvdb.diff

Loading...
View Options

build_files/cmake/platform/platform_win32.cmake

Loading...
View Options

extern/mantaflow/CMakeLists.txt

Loading...
View Options

source/creator/CMakeLists.txt

Loading...