Page MenuHome
Differential D8303

Fix T72621: Transform object origin support for grease-pencil
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Jul 15 2020, 6:18 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Antonio Vazquez (antoniov)
Commits
rB0bfec04cd554: Fix T72621: Transform object origin support for grease-pencil
Summary

Added support for transforming only origins with greasepencil objects.

The new functions is based on BKE_gpencil_transform. That is why there is FIXME statements in there.

Hopefully I didn't miss anything. It seems to work nicely when I did my tests.

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) requested review of this revision.Jul 15 2020, 6:18 PM
Sebastian Parborg (zeddb) created this revision.
Sebastian Parborg (zeddb) mentioned this in T72621: Transform object origin support for grease-pencil.
Antonio Vazquez (antoniov) added a comment.Jul 18 2020, 10:33 AM

I have tested and works, but not sure why you need the pressure. This variable is not related to the scale of the object.

Sebastian Parborg (zeddb) added a comment.Jul 18 2020, 1:56 PM
In D8303#202836, @Antonio Vazquez (antoniov) wrote:

I have tested and works, but not sure why you need the pressure. This variable is not related to the scale of the object.

Are you sure?
If I don't do this and scale the object with "only origins" on, the line thickness will shrink/grow if I don't adjust the pressure.

Campbell Barton (campbellbarton) added a comment.EditedJul 18 2020, 3:01 PM

This looks good to me, assuming the pressure is used for radius this makes sense, if it's used for opacity it wont usefully.

Antonio Vazquez (antoniov) accepted this revision.Jul 18 2020, 4:13 PM

@Sebastian Parborg (zeddb) Ah, right, you are scaling the object and the stroke thickness.

This revision is now accepted and ready to land.Jul 18 2020, 4:13 PM
Closed by commit rB0bfec04cd554: Fix T72621: Transform object origin support for grease-pencil (authored by Sebastian Parborg (zeddb)). · Explain WhyJul 21 2020, 12:13 PM
This revision was automatically updated to reflect the committed changes.
Sebastian Parborg (zeddb) added a commit: rB0bfec04cd554: Fix T72621: Transform object origin support for grease-pencil.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
14 lines
intern/
129 lines
editors/
object/
34 lines

Diff 26834

View Options

source/blender/blenkernel/BKE_gpencil_geom.h

Loading...
View Options

source/blender/blenkernel/intern/gpencil_geom.c

Loading...
View Options

source/blender/editors/object/object_data_transform.c

Loading...