Fix T78426: Use consistent header alignment when switching space types
AbandonedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jul 15 2020, 7:05 PM.

Details

Reviewers

Maniphest Tasks

T78426: Header in 3D View flip from bottom to top if change when changing editor

Summary

The combination of tool headers and regular headers made the checks for
"header" region alignment incorrect. We need to check and set the alignment
for both retion types when switching spaces in order for the alignment to
stay consistent.

Fixes T78426

Diff Detail

Repository

rB Blender

Branch

fix-region-switch-header-alignment (branched from master)

Build Status

Buildable 9026
Build 9026: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 15 2020, 7:05 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B9026: Diff 26839.Jul 15 2020, 7:05 PM

This assumes the header and the tool-header always have the same alignment.

With this patch, if you flip only one of these in the 3D view, change to another view and back - they're moved to being both on the same side.

Checking to see if it's reasonable to sync alignment while supporting them being on different sides.

Otherwise we could:

Enforce then always being on the same side, so "Flip to Top" would always flip both tool-header and header.
Skip syncing in the case they're on different sides.

I ended up applying a more general fix, that detects where the space-selector is shown to avoid header flipping, see: rB73fb445b8dbe88b1ac8e12acd2515618f9e64ac0.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

screen/

area.c

6 lines

Diff 26839

View Options

source/blender/editors/screen/area.c

Fix T78426: Use consistent header alignment when switching space typesAbandonedPublicActions