Fix T78959: Remove check for locked interface before drawing overlays, add comment
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jul 16 2020, 4:04 PM.

Details

Reviewers

Jeroen Bakker (jbakker)

Commits

rB69d14c0ddbfb: Fix T78959: Show current frame indicator when interface is locked

Summary

Removing the check for locked interface seems necessary to get the playhead overlays to draw.
But since it's maybe not the best practice overall, I added a function to get whether
the interface is locked and a comment explaining to check that beforehand in some future cases.

Diff Detail

Repository

rB Blender

Branch

fix-playhead-disappear (branched from master)

Build Status

Buildable 9042
Build 9042: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 16 2020, 4:04 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B9042: Diff 26870.Jul 16 2020, 4:04 PM

Hans Goudey (HooglyBoogly) mentioned this in T78959: Playhead disappears during fluid bake.Jul 16 2020, 4:09 PM

LGTM.

I just double checked where I found the original test, but that is in wm_paintcursor_draw we could. we can use the CTX_wm_interface_locked there. So It doesn't used to happen for the playhead or scrollers.

This revision is now accepted and ready to land.Jul 17 2020, 10:31 AM

Closed by commit rB69d14c0ddbfb: Fix T78959: Show current frame indicator when interface is locked (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJul 17 2020, 9:19 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB69d14c0ddbfb: Fix T78959: Show current frame indicator when interface is locked.