Fix T78994: Clear pose transforms resets all poses even with only_selected
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jul 16 2020, 10:26 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)

Maniphest Tasks

T78994: Armature, pose mode, Clear user transforms reset all despite «only selected» option

Commits

rBd42530824e43: Fix T78994: Clear selected pose doesn't work without animation

Summary

It looks like the code left this as a todo, but the basic solution is to just add
an extra parameter to BKE_bose_rest to check whether bones are selected before reseting them.

I also corrected the operator description which said it acted on only selected bones even when there is an option to turn that off.
The "act on selected" is generally implied for Blender's operators anyway.

Fixes T78994

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) created this revision.Jul 16 2020, 10:26 PM

Harbormaster completed remote builds in B9055: Diff 26887.Jul 16 2020, 10:26 PM

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 16 2020, 10:26 PM

Vyacheslav (hitrpr) awarded a token.Jul 17 2020, 12:47 AM

Thanks for the patch, LGTM except a few small things.

source/blender/blenkernel/intern/action.c
1515–1518	The comment ("the pose") and the implementation ("maybe not all of the pose") are out of sync. Give the state of the comment, I'd say just rewrite it. "Now also ..." doesn't make much sense, and neither does "for do_all_pose_actions" (there is no mention of "do_all_pose_actions" anywhere else in the code).
1515–1518	It's unclear what `selected_only` refers to. `selected_bones_only` seems better to me.
1530	Parentheses are unnecessary here.