CD_PROP_COLOR vertex data is stored in scene linear while legacy vertex
colors are srgb, so both operators also need to do this conversion
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- T79005 (branched from master)
- Build Status
Buildable 9056 Build 9056: arc lint + arc unit
Event Timeline
Comment Actions
From my understanding, the new vertex color should be in the scene linear, not in the linear with rec709 chromaticities. From this point of view you should be using IMB_colormanagement_srgb_to_scene_linear_v3 (the srgb_to_linearrgb_v4 converts rec709 sRGB to linear, which only works with the default OCIO configuration, but will behave wrong when using different configuration).
Comment Actions
The new vertex colors should be scene linear, but the old vertex colors are scene linear + sRGB transfer function, not sRGB. So I think this is correct.
Comment Actions
There isn't really updates, you'll get them automatically if there's any activity in the path,
I am a bit confused with @Brecht Van Lommel (brecht)'s reply though. Brecht, what do you exactly refer to as "this" ?
Comment Actions
I see, thanks for clarification. A bit confusing, but this what it is :)
P.S. We also had a quick in-person discussion. The vertex colors are stored in linear plus sRGB transform, and this is how they are used everywhere. So this patch is correctly following the rest of the areas which are using vertex color.