Page MenuHome
Differential D8322

UI: Use property split for edit custom property popover
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jul 16 2020, 11:46 PM.

Details

Reviewers
Julian Eisel (Severin)
Group Reviewers
User Interface
Commits
rB3d536f69f691: UI: Use property split for custom property edit popover
Summary

The panel looks out of place with the rest of Blender's UI and the text is cropped.
With property split turned on and a few smaller tweaks these issues are fixed.

BeforeAfter

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 16 2020, 11:46 PM
Hans Goudey (HooglyBoogly) created this revision.
Harbormaster completed remote builds in B9057: Diff 26890.Jul 16 2020, 11:46 PM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Jul 16 2020, 11:51 PM
Hans Goudey (HooglyBoogly) edited reviewers, added: User Interface; removed: Brecht Van Lommel (brecht).
Hans Goudey (HooglyBoogly) added a project: User Interface.
Hans Goudey (HooglyBoogly) added inline comments.
release/scripts/startup/bl_operators/wm.py
1457–1458

We could omit "Property" from the name here, but since the width of the popup is fixed there is way too much empty space without it which looks weird.

Julian Eisel (Severin) accepted this revision as: Julian Eisel (Severin).Jul 16 2020, 11:57 PM
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).

Looks like a nice and reasonable improvement.
Didn't test, but code looks fine.

This revision is now accepted and ready to land.Jul 16 2020, 11:57 PM
Closed by commit rB3d536f69f691: UI: Use property split for custom property edit popover (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJul 18 2020, 1:54 AM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB3d536f69f691: UI: Use property split for custom property edit popover.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_operators/
24 lines

Diff 26944

View Options

release/scripts/startup/bl_operators/wm.py

Loading...