Page MenuHome

Fix T77867: Link Duplicate Object crashes during batch creation
AbandonedPublic

Authored by Jeroen Bakker (jbakker) on Jul 17 2020, 1:46 PM.

Details

Summary

When using link duplicated objects it could happen that one object is
calculating the GPUBuffers and the second object is marking these
buffers invalid. This leads to threading issues.

This patch fixes this by combining the surface and surface epr material
batches. Most likely the surface per material batches are used and when
requested they also need the surface batches.

During tests it slightly improves performance as batches aren't thrown
away without using it.

After this patch we can add a quick path for meshes with one material
and two materials.

Alternative approaches that have been checked:

Diff Detail

Repository
rB Blender
Branch
T77867c (branched from master)
Build Status
Buildable 9070
Build 9070: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jul 17 2020, 1:46 PM

Something went wrong when sending a new version of an existing diff.