Differential D8350
Fix Sculpt Relax operation when deforming mesh boundaries Authored by Pablo Dobarro (pablodp606) on Jul 19 2020, 11:43 PM. Tags None Subscribers None Tokens
Details Previously, mesh boundaries were relaxed as any other vertex, which was Now the relax vertex function slides the boundary vertices along the Before: After:
Diff Detail
Event TimelineComment Actions From the description I am not really sure what is causing the artifacts in the current code (before this patch). Such information should be communicated more clearly via patch description and commit messages. Comment Actions Both the brush and the filter were using the SCULPT_relax_vertex function for this deformation, which before this commit it was not preserving the boundaries and it was deforming them in an incorrect way. The workaround was to enable boundary automasking for the brush to lock the boundaries in place (which was not enabled by default). The filter had the boundary automasking functionality hardcoded for preventing these artifacts, but the relax function is the same. This removes all those hacks and lets the SCULPT_relax_vertex handle the boundaries correctly, making vertices slide instead of being locked by the automasking system. Comment Actions
A bit confusing about "the same". So, the auto-masking boundary thing was only hacked to some tools, but not the others?
That's great :) Anyway, code seems fine. Just make sure all the information is summarized in the final commit message. |