Page MenuHome

UI: Fix degree symbol unit consistency
Needs ReviewPublic

Authored by Juan (jc4d) on Jul 23 2020, 9:43 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This patch add another bit of consistency in the input fields. When clicking on a input field for example in the Location, the unit symbol stays visible while typing, but in the case of Rotation that's not the case since the degree symbol is "°" but when the user clicks on the input field it changes to "d" which creates a visual inconsistency.

Moreover, when the user clicks on the input field, the Text Cursor overlaps on the "d" making it visually confusing.

Thanks for your consideration.
Juan

Diff Detail

Repository
rB Blender

Event Timeline

Juan (jc4d) requested review of this revision.Jul 23 2020, 9:43 AM
Juan (jc4d) created this revision.

The "d" is used here so that you can type it, just like "us" for "µs" (microseconds).

There is other issue, if you change "Unit" > "Rotation" to "Radians", you will not see "r",
and what's more, you will not be able to input in degrees (with "d") or in arcminutes/arcseconds.

The "d" is used here so that you can type it, just like "us" for "µs" (microseconds).

There is other issue, if you change "Unit" > "Rotation" to "Radians", you will not see "r",
and what's more, you will not be able to input in degrees (with "d") or in arcminutes/arcseconds.

Thank you for your remarks.

Not sure if this is just a workflow thing, but when I put any value on the Location field I never write the units

I tried my patch and I still can input arcminutes/arcseconds and even "r" after the number and Blender does the conversion , just type the value you want and then the unit text.

If you are in radians and you write a value plus de "d" it will not convert it (tested on the official 2.83.3). So that's a problem in the Blender unit conversion which I'm not touching here.

Maybe I'm didn't understand your comments but for what I can see, my patch doesn't affects the usability.

I mean, this d is used for typing, to indicate units,
since you can't type ° from the keyboard.
If you are in Radians, you should be able to enter d for Degrees.
The current conversion issue is not caused by your patch.

See typedef struct bUnitDef.

/** this is used for display*/
const char *name_short;
/** keyboard-friendly ASCII-only version of name_short, can be NULL */
const char *name_alt;
/* if name_short has non-ASCII chars, name_alt should be present */

I mean, this d is used for typing, to indicate units,
since you can't type ° from the keyboard.
If you are in Radians, you should be able to enter d for Degrees.

@Juan (jc4d) , Thanks for the patch but applying this changes will lead to other problems (as mentioned by jenkm)

(Adding user interface as a tag here so they can decide to close the patch or not) :)