Differential D8374

Fix interface artifacts on Intel GPUs
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Jul 23 2020, 3:17 PM.

Tags

None

Subscribers

Francesco Siddi (fsiddi)

Details

Reviewers

Clément Foucault (fclem)

Commits

rBb7a72778ecf3: Fix interface artifacts on Intel GPUs
rB388639243053: Fix interface artifacts on Intel GPUs

Summary

This is a continuation of fix for T78307. Turns out instancing do not
work at all, so enforce single widget drawing on macOS and Intel GPU.

It was also reported that certain Intel and Mesa driver suffer from
similar issue, so disabled instancing for this configuration as well.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Jul 23 2020, 3:17 PM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B9151: Diff 27076.Jul 23 2020, 3:17 PM

VS Code managed to fai lsaving file, leaving code in the
inconsistent state =\

Harbormaster completed remote builds in B9153: Diff 27079.Jul 23 2020, 3:33 PM

Clément Foucault (fclem) requested changes to this revision.Jul 24 2020, 11:09 AM

Clément Foucault (fclem) added inline comments.

source/blender/editors/interface/interface_widgets.c
1225	it's linux that should be here. not GPU_OS_MAC. also it's amd gpu. see T78803

This revision now requires changes to proceed.Jul 24 2020, 11:09 AM

Address feedback from Clement.

Harbormaster completed remote builds in B9162: Diff 27097.Jul 24 2020, 11:16 AM

Fixed typo in comment.

Harbormaster completed remote builds in B9163: Diff 27098.Jul 24 2020, 11:18 AM

Clément Foucault (fclem) accepted this revision.Jul 24 2020, 11:21 AM

This revision is now accepted and ready to land.Jul 24 2020, 11:21 AM

Closed by commit rB388639243053: Fix interface artifacts on Intel GPUs (authored by Sergey Sharybin (sergey)). · Explain WhyJul 24 2020, 11:24 AM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB388639243053: Fix interface artifacts on Intel GPUs.

Jeroen Bakker (jbakker) added a commit: rBb7a72778ecf3: Fix interface artifacts on Intel GPUs.Aug 12 2020, 9:44 AM

Omar Emara (OmarSquircleArt) mentioned this in D10967: Fix T78803: Bad widget drawing with the R600g driver.Apr 13 2021, 2:53 PM

Omar Emara (OmarSquircleArt) mentioned this in rBd63b72e9f930: Fix T78803: Bad widget drawing with the R600g driver.Apr 13 2021, 10:33 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

interface/

interface_widgets.c

23 lines

Diff 27100

source/blender/editors/interface/interface_widgets.c

Loading...