Page MenuHome
Differential D8375

Fix T79121: Dependency cycle when driver points to prop with 'scale' in name
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Jul 23 2020, 6:09 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T79121: Dependency cycle when driver points to property with 'scale' in name
Commits
rB9b867f2e90bd: Fix T79121: Dependency cycle when driver points to prop with 'scale' in name
Summary

This makes RNANodeQuery::construct_node_identifier() more strict in its matching of certain property names.

The downside of this approach is that it's not possible any more to use "rotation" and expect a match for "rotation_euler" and friends, so the list of strings to test against is now 3x as long.

Diff Detail

Repository
rB Blender
Branch
temp-T79121-depcycle-property-names (branched from master)
Build Status
Buildable 9155
Build 9155: arc lint + arc unit

Revision Contents
Changeset List

PathSize
source/
blender/
depsgraph/
11 lines
intern/
builder/
13 lines
33 lines
60 lines

Diff 27086

View Options

source/blender/depsgraph/CMakeLists.txt

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_rna.h

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_rna.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_rna_test.cc

Loading...