Details

Reviewers

Julian Eisel (Severin)
Campbell Barton (campbellbarton)

Maniphest Tasks

T77824: Properties Search Implementation

Commits

rBa55093711644: UI: Use operator to set property editor's pinned data-block

Summary

>>D8376<<, D8783, D8853, D8854, D8856, D8857, D8858, D8859

This is another change pulled from the property-search-ui branch. This is useful
because it means the pin button doesn't have to be a custom button defined in C.

Replacing the use of button callbacks with operators is always nice too.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 23 2020, 7:20 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B9156: Diff 27087.Jul 23 2020, 7:20 PM

Any reason not to make this an RNA property of the space?

In D8376#204009, @Campbell Barton (campbellbarton) wrote:

Any reason not to make this an RNA property of the space?

There already are the pin_id and use_pin_id properties. I figured an operator would be better than
using a special "set" function for these properties though, since I thought it was generally bad practice
to make setting one property affect another.

Hans Goudey (HooglyBoogly) added a task: T77824: Properties Search Implementation.Sep 2 2020, 5:21 PM

Julian Eisel (Severin) added inline comments.Sep 8 2020, 12:27 PM

source/blender/editors/space_buttons/buttons_ops.c
63	`rna_SpaceProperties_pin_id_update()` does additional things to ensure correct material preview updates and to unpin the context if `sbuts->pinid` is `NULL`. Maybe it's better to set the values through RNA, and let that deal with updates and invariants?

Merge branch 'master' into properties-pin-operator
Use RNA to set the pin ID

Harbormaster completed remote builds in B10084: Diff 28695.Sep 9 2020, 5:54 PM

Julian Eisel (Severin) accepted this revision.Sep 9 2020, 6:01 PM

This revision is now accepted and ready to land.Sep 9 2020, 6:01 PM

Hans Goudey (HooglyBoogly) retitled this revision from UI: Use an operator to set the property editor's pinned data-block to Property Search: Use an operator to set the property editor's pinned data-block.Sep 9 2020, 6:58 PM

Hans Goudey (HooglyBoogly) added a project: User Interface.

Hans Goudey (HooglyBoogly) added a project: BF Blender (2.91).

Hans Goudey (HooglyBoogly) added a child revision: D8783: Property Search: Search with button groups.Sep 9 2020, 7:10 PM

Hans Goudey (HooglyBoogly) mentioned this in D8859: Property Search: All tabs.Sep 9 2020, 8:50 PM

Hans Goudey (HooglyBoogly) mentioned this in D8858: Property Search: Add highlight arguments to tab buttons.

Hans Goudey (HooglyBoogly) mentioned this in D8857: Property Search: Quick start and clear operators.

Hans Goudey (HooglyBoogly) mentioned this in D8856: Property Search: Single tab.

Hans Goudey (HooglyBoogly) mentioned this in D8854: Property Search: Add "Search match" theme color.Sep 9 2020, 8:54 PM

Hans Goudey (HooglyBoogly) mentioned this in D8853: Property Search: Move properties context buttons back to a panel.

Hans Goudey (HooglyBoogly) mentioned this in D8783: Property Search: Search with button groups.

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Campbell Barton (campbellbarton) accepted this revision.Sep 10 2020, 11:40 AM