Page MenuHome
Differential D837

Numerical input for changing brush size, strenght or angle.
ClosedPublic
Actions

Authored by Martin Vykoukal (braffe) on Oct 20 2014, 3:14 PM.

Details

Reviewers
Antonis Ryakiotakis (psy-fi)
Group Reviewers
Sculpt, Paint & Texture
Commits
rBSe103c9773f14: Numerical input for changing brush size, strenght or angle.
rBe103c9773f14: Numerical input for changing brush size, strenght or angle.
Summary

This patch adds ability to change brush parameters with keyboard, which is missing functionality from 2.4x.
Original report: T28811

Diff Detail

Repository
rB Blender

Event Timeline

Martin Vykoukal (braffe) updated this revision to Diff 2737.Oct 20 2014, 3:14 PM
Martin Vykoukal (braffe) retitled this revision from to Numerical input for changing brush size, strenght or angle..
Martin Vykoukal (braffe) updated this object.
Martin Vykoukal (braffe) added a project: Sculpt, Paint & Texture.
Martin Vykoukal (braffe) added a subscriber: Martin Vykoukal (braffe).Oct 20 2014, 3:17 PM
Martin Vykoukal (braffe) updated this object.Oct 20 2014, 3:25 PM
Martin Vykoukal (braffe) added a reviewer: Sculpt, Paint & Texture.Oct 20 2014, 3:49 PM
Martin Vykoukal (braffe) updated this object.Oct 20 2014, 4:03 PM
Martin Vykoukal (braffe) added a reviewer: Antonis Ryakiotakis (psy-fi).
Antonis Ryakiotakis (psy-fi) edited edge metadata.Oct 20 2014, 4:33 PM

Added a few notes, I will test functionality later.

source/blender/windowmanager/intern/wm_operators.c
3717

Minor typo here

3750

I would use the property name instead of hardcoding those in. Same below.

4158

probably "none" unit make sense better here

4382

This looks redundant. I've seen such code elsewhere (can't remember where off-hand) but I don't think this can ever happen. Have you noticed any case where it is needed?

Martin Vykoukal (braffe) added inline comments.Oct 20 2014, 9:05 PM
source/blender/windowmanager/intern/wm_operators.c
4158

Can I just write: rc->num_input.unit_sys = USER_UNIT_NONE ? Or is there another better way to do that?

4382

When radial control is invoked for the first time has_numInput returns false and therefore whole condition on the line 4246 cannot be true. This is workaround for that problem. Same code is also in bevel and inset tools.

Martin Vykoukal (braffe) updated this revision to Diff 2824.Nov 3 2014, 1:07 PM
Martin Vykoukal (braffe) edited edge metadata.

Hardcoded text and typo are removed, unit system is now set to none.

Martin Vykoukal (braffe) updated this revision to Diff 2897.Nov 17 2014, 3:31 PM

Better RNA property name printing.

Closed by commit rBe103c9773f14: Numerical input for changing brush size, strenght or angle. (authored by Antonis Ryakiotakis (psy-fi)). · Explain WhyNov 17 2014, 4:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
windowmanager/
intern/
317 lines

Diff 2899

View Options

source/blender/windowmanager/intern/wm_operators.c

Loading...