Page MenuHome

Deps: Basic build support for gmp
ClosedPublic

Authored by Ray Molenkamp (LazyDodo) on Jul 24 2020, 6:11 PM.

Details

Summary

With the newboolean branch heading towards master best to get the required gmp
lib scripted sooner rather than later

Diff Detail

Repository
rB Blender
Branch
tmp_gmp_dep (branched from master)
Build Status
Buildable 9168
Build 9168: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) requested review of this revision.Jul 24 2020, 6:11 PM
Brecht Van Lommel (brecht) edited the summary of this revision. (Show Details)

Linux and (untested) macOS support

Disable WITH_GMP by default until it is actually used

think @Howard Trickey (howardt) is looking to land this in master sooner rather than later, didn't think an option was warranted.

Add option to various configurations.

We have options for practically all non-required library dependencies, primarily for lite builds I think. GMP should follow that.

I can make my new boolean code be disabled if there is no GMP enabled - it would then only expose the old Boolean. I can see how this might be useful for a developer who wants faster builds (and not working in the modeling area), or if there's some problem building or linking with GMP sometime in the future and someone just wants a way to build a workable Blender.
But if we get to the point where it is in master and we want feedback on the new Boolean, then I would hope that the nightly builds would enable WITH_GMP.

Blender should continue to build without GMP even if new booleans are not available then (or only using fixed precision?).

We can enable WITH_GMP once the boolean code is in master and the precompiled libraries are available.

But for coordination it's easier to commit this disabled as a first step, then commit the libraries and test it works correctly, and then enable it for everyone.

This revision is now accepted and ready to land.Jul 30 2020, 6:58 PM

Deps builder is in, but keeping this open until all platforms have landed

This revision is now accepted and ready to land.Jul 31 2020, 5:37 PM
Sergey Sharybin (sergey) edited the summary of this revision. (Show Details)Aug 3 2020, 2:20 PM
Brecht Van Lommel (brecht) edited the summary of this revision. (Show Details)
Brecht Van Lommel (brecht) edited the summary of this revision. (Show Details)