Page MenuHome

Cleanup: UI: Fix capitalization
ClosedPublic

Authored by Yevgeny Makarov (jenkm) on Jul 27 2020, 8:20 AM.

Diff Detail

Repository
rB Blender

Event Timeline

Yevgeny Makarov (jenkm) requested review of this revision.Jul 27 2020, 8:20 AM
Yevgeny Makarov (jenkm) created this revision.
Ankit Meel (ankitm) retitled this revision from UI: Fix capitalization 2 to Cleanup: UI: Fix capitalization.Aug 1 2020, 2:55 PM
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 16 2020, 10:44 PM
Harley Acheson (harley) added inline comments.
source/blender/editors/mesh/editmesh_select_similar.c
86

I think this should be "Coplanar" as that is a proper word.

source/blender/editors/space_clip/tracking_ops.c
1046

Should this not be "Clear Up To" ? There isn't any usage of compound word "up-to"

source/blender/makesrna/intern/rna_color.c
799

This should be the single word "Filmlike"

source/blender/makesrna/intern/rna_userdef.c
4784

I don't think Mono-space is a word. "Monospaced" is generally used here. There are compound alternatives like fixed-pitch, fixed-width, and non-proportional. But "Monospaced font" is probably what we want.

Hans Goudey (HooglyBoogly) requested changes to this revision.Oct 20 2020, 6:11 PM

Generally this looks good! I don't see any changes that don't match the MLA style.

Harley's comments should be addressed I think, but other than that I think this is good to go.

This revision now requires changes to proceed.Oct 20 2020, 6:11 PM

Same here, as long as everything follows the MLA style, and Harley's comments are addressed, this is fine. Great!

Hmmm... I can't get this to apply to master no matter what I do (its from July).

This weekend I will update this, add the changes that I suggested, and will update this patch. Should then just be a quick double-check (by anyone else) then I can commit it with Yevgeny as author.

Hmmm.... I thought I could just update this diff myself but it only lets me make a new one. Following is the this patch, updated to current master with only small changes:

Yevgeny Makarov (jenkm) marked 4 inline comments as done.

Two changes over the Harley's version:

"Softbody & Cloth" - ampersand is ok for labels and menu items, https://developer.blender.org/D8345#223350.
In this case it also means that these are not two different groups of settings but the same common settings for both. They are closer, connected.

"Tracks for Rotation/Scale" vs "Tracks for Rotation / Scale" - these are two different meanings.

  • (Tracks for Rotation) or/and (Tracks for Scale)
  • (Tracks for Rotation) or/and (Scale)

@Yevgeny Makarov (jenkm) -

I did make that ampersand change, only because it is not recommended MLA style. But I seriously don't mind either way. It looks nice short. And we can always change it later if we codify the other way.

I also didn't do your change of "Add-On Bug" to "Add-on Bug" (in WM_OT_url_open_preset in wm.py) because it kept looking wrong and didn't seem to match the capitalization of other compound words. Checked in some online MLA title-checking tool.

I think we have a GTG unless you want to change that "Add-On Bug"

I changed "Add-On Bug" to "Add-on Bug" because I saw "Add-on" / "Enabled Add-ons Only" in the Preferences. (And probably in other places too.)
But, yes, probably "Add-On" is more correct, although outwardly more beautiful "Add-on".

This revision is now accepted and ready to land.Oct 24 2020, 8:48 PM
This revision was automatically updated to reflect the committed changes.