CMake: reject older GCC version when using precompiled Linux libraries
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Jul 27 2020, 2:57 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Commits

rBa5b2aa96e4a7: CMake: reject older GCC version when using precompiled Linux libraries

Summary

In the situation where the precompiled libraries are used on Linux + GCC, a version of GCC older than 9.3 is guaranteed to cause problems.

This just implents a fatal error message when we know it doesn't make sense to continue. We could do more checks and add some warnings, but it's very likely that these will be ignored amongst the other noise.

Diff Detail

Repository

rB Blender

Branch

temp-cmake-gcc-linux-compiler-version-check

Build Status

Buildable 9190
Build 9190: arc lint + arc unit

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Jul 27 2020, 2:57 PM

Sybren A. Stüvel (sybren) created this revision.

Harbormaster completed remote builds in B9187: Diff 27141.Jul 27 2020, 2:57 PM

Brecht Van Lommel (brecht) added inline comments.Jul 27 2020, 3:23 PM

build_files/cmake/platform/platform_unix.cmake
40	Use `CMAKE_COMPILER_IS_GNUCC`
42	Maybe change to: message(FATAL_ERROR "GCC version must be at least 9.3 for precompiled libraries, found ${CMAKE_C_COMPILER_VERSION}")