Page MenuHome

Fix T79357: VSE crash on prefetching when performing cuts
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Jul 29 2020, 3:04 PM.

Details

Summary

Caused by rBa1a333a1e92e: Fix T76774: Crash on prefetching sequences from another scene.

BKE_sequencer_prefetch_get_original_sequence cant get a sequence in
BKE_sequencer_cache_put.

rBa1a333a1e92e moved multiple NULL checks (including the one checking
seq) above BKE_sequencer_prefetch_get_original_sequence (this should
never return NULL really, but this is for another fix).

So solution suggested by @Richard Antalik (ISS) is to just stop prefetching all together
before changing content of seqbase.

Diff Detail

Repository
rB Blender
Branch
T79357 (branched from master)
Build Status
Buildable 9261
Build 9261: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Jul 29 2020, 3:04 PM
This revision is now accepted and ready to land.Jul 29 2020, 5:11 PM
Richard Antalik (ISS) requested changes to this revision.Jul 29 2020, 10:02 PM

This would be probably harmless fix, but BKE_sequencer_prefetch_get_original_sequence should not return NULL. I should put assert here. Best solution for now would be same as in D8256.

In future we should stop prefetching in BKE_sequencer_remove_flagged_sequences and use only this function to remove strips.

This revision now requires changes to proceed.Jul 29 2020, 10:02 PM

stop prefetching all together before performing cuts

Can't really test now, but I assume this will work.

This revision is now accepted and ready to land.Jul 30 2020, 4:36 PM