Page MenuHome
Differential D8423

Cleanup: converted Depsgraph Building Pipeline to object-oriented code
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Jul 29 2020, 6:21 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T75936: Objects not exported to Alembic if disabled in render
Commits
rB3642cbb1d2c9: Cleanup: converted Depsgraph Building Pipeline to object-oriented code
Summary

This will make it easier & cleaner to make custom-built depsgraph (for example for exporting invisible objects to USD or Alembic, see T75936).

No functional changes.

Diff Detail

Repository
rB Blender

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Jul 29 2020, 6:21 PM
Sybren A. Stüvel (sybren) created this revision.
Harbormaster completed remote builds in B9244: Diff 27261.Jul 29 2020, 6:21 PM
Sybren A. Stüvel (sybren) added a task: T75936: Objects not exported to Alembic if disabled in render.Jul 29 2020, 6:22 PM
Sergey Sharybin (sergey) requested changes to this revision.Jul 29 2020, 6:38 PM

Generally fine, just some super simple thing to address.

source/blender/depsgraph/intern/builder/pipeline.h
29

Use depsgraph_type.h and unique_ptr from the deg namespace.

This revision now requires changes to proceed.Jul 29 2020, 6:38 PM
Evan Wilson (EAW) awarded a token.Jul 31 2020, 12:00 AM
Kenzie (kenziemac130) awarded a token.Aug 1 2020, 9:33 PM
Sybren A. Stüvel (sybren) updated this revision to Diff 27382.Aug 4 2020, 10:35 AM
  • std::unique_ptr → unique_ptr
Harbormaster completed remote builds in B9327: Diff 27382.Aug 4 2020, 10:36 AM
Sergey Sharybin (sergey) accepted this revision.Aug 4 2020, 11:12 AM

LGTM

This revision is now accepted and ready to land.Aug 4 2020, 11:12 AM
Closed by commit rB3642cbb1d2c9: Cleanup: converted Depsgraph Building Pipeline to object-oriented code (authored by Sybren A. Stüvel (sybren)). · Explain WhyAug 4 2020, 11:36 AM
This revision was automatically updated to reflect the committed changes.
Sybren A. Stüvel (sybren) added a commit: rB3642cbb1d2c9: Cleanup: converted Depsgraph Building Pipeline to object-oriented code.

Revision Contents
Changeset List

PathSize
source/
blender/
depsgraph/
10 lines
intern/
builder/
77 lines
132 lines
47 lines
49 lines
62 lines
154 lines
41 lines
49 lines
41 lines
48 lines
261 lines

Diff 27389

View Options

source/blender/depsgraph/CMakeLists.txt

Loading...
View Options

source/blender/depsgraph/intern/builder/pipeline.h

Loading...
View Options

source/blender/depsgraph/intern/builder/pipeline.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/pipeline_compositor.h

Loading...
View Options

source/blender/depsgraph/intern/builder/pipeline_compositor.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/pipeline_from_ids.h

Loading...
View Options

source/blender/depsgraph/intern/builder/pipeline_from_ids.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/pipeline_render.h

Loading...
View Options

source/blender/depsgraph/intern/builder/pipeline_render.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/pipeline_view_layer.h

Loading...
View Options

source/blender/depsgraph/intern/builder/pipeline_view_layer.cc

Loading...
View Options

source/blender/depsgraph/intern/depsgraph_build.cc

Loading...