Previously, deform brushes were modifying the final positions in the
simulation directly, which was causing all sorts of artifacts in the
deformed area and problems with other features of the solver.
Now these brushes deform a separate array of positions and the solver
adds constraints to them, so the real vertices are moved when solving
the constraints. This prevents those artifacts and gives the brush a
much better behavior.
Before:
After:
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- sculpt-cloth-grab-constraints (branched from master)
- Build Status
Buildable 9245 Build 9245: arc lint + arc unit
Event Timeline
Comment Actions
Generally fine, and the video comparison looks great. Also kudos for showing before/after ;)
However, see inlined comments for simple things.
| source/blender/editors/sculpt_paint/sculpt_cloth.c | ||
|---|---|---|
| 212 | radius_squared = ss->cache->initial_radius * ss->cache->initial_radius; pow2f is slower. | |
| 471 | MEM_calloc_arrayN | |